From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hamish Moffatt Date: Wed, 3 Sep 2008 15:21:10 +1000 Subject: [Buildroot] rfc: autotools xyz-clean target doesn't remove stamp files Message-ID: <20080903052110.GA11847@cloud.net.au> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net I noticed that the xyz-clean and xyz-uninstall targets generated by Makefile.autotools.in don't remove the relevant stamp files. The result is that if you make xyz-clean, making xyz again doesn't do anything. I think this is simply a bug and propose the following patch. However this is the first time I've used Makefile.autotools.in so I ask for feedback here.. While we're at it, xyz-clean should probably just call xyz-uninstall first rather than duplicating those lines. And some sort of post-uninstall (or pre-uninstall) hook is probably relevant in some scenarios, since we have a post-install hook. thanks, Hamish Index: package/Makefile.autotools.in =================================================================== --- package/Makefile.autotools.in (revision 6304) +++ package/Makefile.autotools.in (working copy) @@ -250,13 +250,18 @@ $(BUILD_DIR)/%/.stamp_cleaned: $(call MESSAGE,"Cleaning up") -$($(PKG)_MAKE_ENV) $(MAKE) $($(PKG)_UNINSTALL_STAGING_OPT) -C $(@D)/$($(PKG)_SUBDIR) + rm -f $(@D)/.stamp_staging_installed -$($(PKG)_MAKE_ENV) $(MAKE) $($(PKG)_UNINSTALL_TARGET_OPT) -C $(@D)/$($(PKG)_SUBDIR) + rm -f $(@D)/.stamp_target_installed -$($(PKG)_MAKE_ENV) $(MAKE) $($(PKG)_CLEAN_OPT) -C $(@D)/$($(PKG)_SUBDIR) + rm -f $(@D)/.stamp_built $(BUILD_DIR)/%/.stamp_uninstalled: $(call MESSAGE,"Uninstalling") $($(PKG)_MAKE_ENV) $(MAKE) $($(PKG)_UNINSTALL_STAGING_OPT) -C $(@D)/$($(PKG)_SUBDIR) + rm -f $(@D)/.stamp_staging_installed $($(PKG)_MAKE_ENV) $(MAKE) $($(PKG)_UNINSTALL_TARGET_OPT) -C $(@D)/$($(PKG)_SUBDIR) + rm -f $(@D)/.stamp_target_installed $(BUILD_DIR)/%/.stamp_dircleaned: rm -Rf $(@D) -- Hamish Moffatt VK3SB