From: Hamish Moffatt <hamish@cloud.net.au>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Ignore errors on rmdir in clean-targets; retry
Date: Wed, 10 Sep 2008 20:47:50 +1000 [thread overview]
Message-ID: <20080910104750.GA18852@cloud.net.au> (raw)
In-Reply-To: <20080910081110.GA24785@aeon.hgd.crondor.net>
On Wed, Sep 10, 2008 at 10:11:10AM +0200, Michel Wilson wrote:
> Hi,
>
> Same patch, better mailer :)
> As stated before, makes various clean-targets behave when some
> directories it tries to remove are missing.
Not just clean targets, fwiw:
> Index: target/jffs2/jffs2root.mk
> ===================================================================
> --- target/jffs2/jffs2root.mk (revision 23359)
> +++ target/jffs2/jffs2root.mk (working copy)
> @@ -58,7 +58,7 @@
> ifneq ($(BR2_HAVE_INFOPAGES),y)
> @rm -rf $(TARGET_DIR)/usr/info
> endif
> - @rmdir -p --ignore-fail-on-non-empty $(TARGET_DIR)/usr/share
> + @-rmdir -p --ignore-fail-on-non-empty $(TARGET_DIR)/usr/share
> $(if $(TARGET_LDCONFIG),test -x $(TARGET_LDCONFIG) && $(TARGET_LDCONFIG) -r $(TARGET_DIR) 2>/dev/null)
> # Use fakeroot to pretend all target binaries are owned by root
> rm -f $(PROJECT_BUILD_DIR)/_fakeroot.$(notdir $(JFFS2_TARGET))
That's not in the clean target.
> Index: target/cloop/cloop.mk
> ===================================================================
> --- target/cloop/cloop.mk (revision 23359)
> +++ target/cloop/cloop.mk (working copy)
> @@ -71,7 +71,7 @@
> @rm -rf $(TARGET_DIR)/usr/info
> @rm -rf $(TARGET_DIR)/usr/share/info
> endif
> - @rmdir -p --ignore-fail-on-non-empty $(TARGET_DIR)/usr/share
> + @-rmdir -p --ignore-fail-on-non-empty $(TARGET_DIR)/usr/share
> which mkisofs
> - at find $(TARGET_DIR) -type f -perm +111 | xargs $(STRIPCMD) 2>/dev/null || true
> - which symlinks && symlinks -r $(TARGET_DIR)
That's in check-tools target. (Which incidentally appears to be
namespace polution - cloop should prefix its target names with cloop.)
All this use of @... appears to be unnecessary information hiding too.
(Not blaming your patch for this of course.)
/usr/share is a standard system directory probably present in the target
skeleton, so it doesn't seem right for any package to be removing it
anyway.
Hamish
--
Hamish Moffatt VK3SB <hamish@debian.org> <hamish@cloud.net.au>
prev parent reply other threads:[~2008-09-10 10:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-10 8:11 [Buildroot] [PATCH] Ignore errors on rmdir in clean-targets; retry Michel Wilson
2008-09-10 10:47 ` Hamish Moffatt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080910104750.GA18852@cloud.net.au \
--to=hamish@cloud.net.au \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox