Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com>
To: buildroot@busybox.net
Subject: [Buildroot] Error in xserver_xorg-server.mk?
Date: Tue, 30 Sep 2008 09:35:34 +0200	[thread overview]
Message-ID: <20080930093534.0b5e072d@atmel.com> (raw)
In-Reply-To: <49ED01FC03EE524BB7BB258E8F93BFF32B2750@bfl-exchange-1.BFL.local>

On Tue, 30 Sep 2008 09:01:54 +0200
"Matuschka, Sebastian" <Sebastian.Matuschka@gcd-solutions.de> wrote:

> Hi All,
> 
> i guess that in the file xservers_xorg-server.mk the block
> 

I guess you meant the file
package/x11r7/xserver_xorg-server/xserver_xorg-server.mk ;)

Feel free to make a patch and send that in the future, easier to apply
and understand where you have spotted the error.

> XSERVER_XORG_SERVER_CONF_OPT = $(XSERVER_XORG_ENABLE_KDRIVE) \
> 		--enable-freetype $(XSERVER_XORG_ENABLE_MODULAR) \
> 		--disable-config-hal $(XSERVER_XORG_MESA_DIR) \
> 		--disable-xnest --disable-xephyr --disable-xvfb \
> 		$(XSERVER_XORG_NULL_CURSOR) 
> 		CFLAGS="-I$(STAGING_DIR)/usr/include/pixman-1"
> 
> should be:
> 
> XSERVER_XORG_SERVER_CONF_OPT = $(XSERVER_XORG_ENABLE_KDRIVE) \
> 		--enable-freetype $(XSERVER_XORG_ENABLE_MODULAR) \
> 		--disable-config-hal $(XSERVER_XORG_MESA_DIR) \
> 		--disable-xnest --disable-xephyr --disable-xvfb \
> 		$(XSERVER_XORG_NULL_CURSOR) \
> 		CFLAGS="-I$(STAGING_DIR)/usr/include/pixman-1"
> 
> 
> There is no \ after $(XSERVER_XORG_NULL_CURSOR), but it should be
> there and was there before the last commit to the file, where
> $(XSERVER_XORG_NULL_CURSOR) was added.
> 

Seems correct by me, I have added the backslash to trunk, see revision
23562.

-- 
Best regards,
Hans-Christian Egtvedt

      reply	other threads:[~2008-09-30  7:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-30  7:01 [Buildroot] Error in xserver_xorg-server.mk? Matuschka, Sebastian
2008-09-30  7:35 ` Hans-Christian Egtvedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080930093534.0b5e072d@atmel.com \
    --to=hans-christian.egtvedt@atmel.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox