Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Heidelberg <markus.heidelberg@web.de>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package: remove/replace PKG_CONFIG_SYSROOT
Date: Sun, 26 Oct 2008 14:37:57 +0200	[thread overview]
Message-ID: <200810261337.58158.markus.heidelberg@web.de> (raw)
In-Reply-To: <20081025205424.78d812d4@surf>

Thomas Petazzoni, 25.10.2008:
> Le Sat, 25 Oct 2008 01:08:06 +0200,
> Markus Heidelberg <markus.heidelberg@web.de> a ?crit :
> 
> > PKG_CONFIG_SYSROOT is not recognized by pkg-config,
> > PKG_CONFIG_SYSROOT_DIR is the valid environment variable name.
> 
> These variables are already defined in TARGET_CONFIGURE_OPTS in
> package/Makefile.in. Just drop them in your packages.

I know, so I just removed it in libogg and libvorbis. Docker uses
Makefile.autotools.in, here I forgot to just remove it. In vim
TARGET_CONFIGURE_OPTS are not used, so I had to change SYSROOT to SYSROOT_DIR.
I don't use any of these packages but wanted to get rid of the wrong
PKG_CONFIG_SYSROOT_DIR variables in Buildroot, confusing me while working on
other packages using pkg-config. I don't wanted to risk side effects, so I did
the minimal work.

When cleaning up the PKG_CONFIG stuff, there are 12 packages defining these
variables on their own instead of using them from Makefile.in:

find package -name *.mk -exec echo {} \; -exec grep -w "PKG_CONFIG\(\|_PATH\|SYSROOT_DIR\)" {} \; | grep PKG_CONFIG -B 1

Also, since libogg and libvorbis used /lib/pkgconfig in addition to the normal
/usr/lib/pkgconfig I just kept it in there.

Markus

      parent reply	other threads:[~2008-10-26 12:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-24 23:08 [Buildroot] [PATCH] package: remove/replace PKG_CONFIG_SYSROOT Markus Heidelberg
2008-10-25 18:54 ` Thomas Petazzoni
2008-10-26  6:20   ` Peter Korsgaard
2008-10-26 12:37   ` Markus Heidelberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200810261337.58158.markus.heidelberg@web.de \
    --to=markus.heidelberg@web.de \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox