From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bernhard Reutner-Fischer Date: Fri, 31 Oct 2008 14:26:48 +0100 Subject: [Buildroot] [PATCH] Create zlib installation directory in the staging dir In-Reply-To: References: <20081030170039.6fe37578@surf> <20081031083736.GB26468@mx.loc> <20081031121558.GB27517@mx.loc> Message-ID: <20081031132648.GE27517@mx.loc> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On Fri, Oct 31, 2008 at 10:44:20AM -0200, Thiago A. Corr?a wrote: >On Fri, Oct 31, 2008 at 10:15 AM, Bernhard Reutner-Fischer > wrote: >> On Fri, Oct 31, 2008 at 10:11:04AM -0200, Thiago A. Corr?a wrote: >>>Applied in r23879. >> >> You applied something different, fwiw. But it doesn't matter much, >> you're building zlib incorrectly anyway *shrug* i've fixed this now.. >> > >Diff between svn and git gives me: > >-$(TARGET_DIR)/usr/lib/libz.a: $(STAGING_DIR)/usr/lib/libz.so >- $(INSTALL) -D $(STAGING_DIR)/usr/include/zlib.h >$(TARGET_DIR)/usr/include/ >- $(INSTALL) $(STAGING_DIR)/usr/include/zconf.h $(TARGET_DIR)/usr/include/ >- $(INSTALL) -D $(STAGING_DIR)/usr/lib/libz.a $(TARGET_DIR)/usr/lib/ >+$(TARGET_DIR)/usr/lib/libz.a: $(STAGING_DIR)/usr/lib/libz.so.$(ZLIB_VERSION) >+ mkdir -p $(TARGET_DIR)/usr/include $(TARGET_DIR)/usr/lib >+ cp -dpf $(STAGING_DIR)/usr/include/zlib.h $(TARGET_DIR)/usr/include/ >+ cp -dpf $(STAGING_DIR)/usr/include/zconf.h $(TARGET_DIR)/usr/include/ >+ cp -dpf $(STAGING_DIR)/usr/lib/libz.a $(TARGET_DIR)/usr/lib/ >+ rm -f $(TARGET_DIR)/lib/libz.so $(TARGET_DIR)/usr/lib/libz.so >+ ln -sf libz.so.$(ZLIB_VERSION) $(TARGET_DIR)/usr/lib/libz.so > touch -c $@ > >Why not use $(INSTALL) here? That's what I did in addition to that >point where you and Thomas pointed out. I overlooked that you creaded the dirs before installing the files, so this is ok, sorry.