From mboxrd@z Thu Jan 1 00:00:00 1970 From: jacmet at uclibc.org Date: Mon, 3 Nov 2008 02:32:59 -0800 (PST) Subject: [Buildroot] svn commit: trunk/buildroot/toolchain/external-toolchain Message-ID: <20081103103259.91CE53C685@busybox.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Author: jacmet Date: 2008-11-03 02:32:59 -0800 (Mon, 03 Nov 2008) New Revision: 23909 Log: More external toolchain fixes Fix issues with binary external toolchains Fix two problems encountered while using an external binary toolchain generated by crosstool-ng: - Don't remove the ending / in LIB_DIR, otherwise find $LIB_DIR -maxdepth 1 doesn't find any file in the case LIB_DIR is a symbolic link and not a directory. For some reason, find -maxdepth 1 doesn't have the same behaviour on directories and symbolic links. Demonstration: $ mkdir foobar $ touch foobar/t1 $ touch foobar/t2 $ ln -s foobar barfoo $ find foobar -maxdepth 1 -name 't*' foobar/t1 foobar/t2 $ find barfoo -maxdepth 1 -name 't*' $ find barfoo/ -maxdepth 1 -name 't*' barfoo/t1 barfoo/t2 * Make sure the libraries are writable, otherwise the strip operation might fail. The library files may not be writable if the toolchain is not writable (which may happen if one wants to prevent anyone from overwriting the toolchain, which is done by crosstool-ng, for example). Signed-off-by: Thomas Petazzoni Modified: trunk/buildroot/toolchain/external-toolchain/ext-tool.mk Changeset: Modified: trunk/buildroot/toolchain/external-toolchain/ext-tool.mk =================================================================== --- trunk/buildroot/toolchain/external-toolchain/ext-tool.mk 2008-11-03 10:18:39 UTC (rev 23908) +++ trunk/buildroot/toolchain/external-toolchain/ext-tool.mk 2008-11-03 10:32:59 UTC (rev 23909) @@ -10,7 +10,7 @@ DST="$(strip $2)"; \ STRIP="$(strip $3)"; \ \ - LIB_DIR=`$(TARGET_CC) -print-file-name=$${LIB} | sed -e "s,/$${LIB}\$$,,"`; \ + LIB_DIR=`$(TARGET_CC) -print-file-name=$${LIB} | sed -e "s,$${LIB}\$$,,"`; \ \ if test -z "$${LIB_DIR}"; then \ echo "copy_toolchain_lib_root: lib=$${LIB} not found"; \ @@ -27,7 +27,7 @@ if test -h $${LIB_DIR}/$${LIB}; then \ cp -d $${LIB_DIR}/$${LIB} $(TARGET_DIR)$${DST}/; \ elif test -f $${LIB_DIR}/$${LIB}; then \ - cp $${LIB_DIR}/$${LIB} $(TARGET_DIR)$${DST}/$${LIB}; \ + $(INSTALL) -D -m0755 $${LIB_DIR}/$${LIB} $(TARGET_DIR)$${DST}/$${LIB}; \ case "$${STRIP}" in \ (0 | n | no) \ ;; \