Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] target/iso9660/iso9660.mk
Date: Fri, 21 Nov 2008 11:32:42 +0100	[thread overview]
Message-ID: <20081121103242.GB19111@mx.loc> (raw)
In-Reply-To: <e4c675870811210211s3080d990ue4b59efe2c4a3d68@mail.gmail.com>

On Fri, Nov 21, 2008 at 11:11:59AM +0100, Roberto A. Foglietta wrote:
>Hi,
>
> when the user choose to use INITRAMFS iso9660 double its size because
>initrd is also copied in iso9660 but kernel has its own.
>
>
>Index: target/iso9660/iso9660.mk
>===================================================================
>--- target/iso9660/iso9660.mk	(revision 24103)
>+++ target/iso9660/iso9660.mk	(working copy)
>@@ -55,12 +55,17 @@
> endif
>
> $(ISO9660_TARGET): host-fakeroot $(LINUX_KERNEL) $(EXT2_TARGET) grub mkisofs
>+	rm -rf $(ISO9660_TARGET_DIR)
> 	mkdir -p $(ISO9660_TARGET_DIR)
> 	mkdir -p $(ISO9660_TARGET_DIR)/boot/grub
> 	cp $(GRUB_DIR)/stage2/stage2_eltorito $(ISO9660_TARGET_DIR)/boot/grub/
> 	cp $(ISO9660_BOOT_MENU) $(ISO9660_TARGET_DIR)/boot/grub/menu.lst
> 	cp $(LINUX_KERNEL) $(ISO9660_TARGET_DIR)/kernel
>+ifneq ($(strip $(BR2_TARGET_ROOTFS_INITRAMFS)),y)

the strip is superfluous (other patches of yours also do this. Don't.)

> 	cp $(EXT2_TARGET) $(ISO9660_TARGET_DIR)/initrd
>+else
>+	touch $(ISO9660_TARGET_DIR)/initrd

Sounds like this is not needed?

I have applied something equivalent to my tree. Thanks.

  reply	other threads:[~2008-11-21 10:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-21 10:11 [Buildroot] [PATCH] target/iso9660/iso9660.mk Roberto A. Foglietta
2008-11-21 10:32 ` Bernhard Reutner-Fischer [this message]
2008-11-21 10:48   ` Roberto A. Foglietta
2008-11-21 11:11     ` Bernhard Reutner-Fischer
2008-11-21 11:22       ` Roberto A. Foglietta
2008-11-21 11:50         ` Bernhard Reutner-Fischer
2008-11-21 12:04           ` Roberto A. Foglietta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081121103242.GB19111@mx.loc \
    --to=rep.dot.nop@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox