From: egtvedt at uclibc.org <egtvedt@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] svn commit: trunk/buildroot/package/multimedia/mplayer
Date: Mon, 1 Dec 2008 05:33:33 -0800 (PST) [thread overview]
Message-ID: <20081201133333.84D033C6F3@busybox.net> (raw)
Author: egtvedt
Date: 2008-12-01 05:33:33 -0800 (Mon, 01 Dec 2008)
New Revision: 24214
Log:
mplayer: use $(if ...) to add dependencies to mplayer
This patch will add needed libraries with $(if ...) syntax. This should ease
readability and make it easy for others to spot where the depencies are added.
Signed-off-by: Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com>
Modified:
trunk/buildroot/package/multimedia/mplayer/mplayer.mk
Changeset:
Modified: trunk/buildroot/package/multimedia/mplayer/mplayer.mk
===================================================================
--- trunk/buildroot/package/multimedia/mplayer/mplayer.mk 2008-12-01 13:08:43 UTC (rev 24213)
+++ trunk/buildroot/package/multimedia/mplayer/mplayer.mk 2008-12-01 13:33:33 UTC (rev 24214)
@@ -17,12 +17,6 @@
MPLAYER_ENDIAN:=--disable-big-endian
endif
-MPLAYER_DEP_LIBS:=libmad
-
-ifeq ($(BR2_PACKAGE_ALSA_LIB),y)
-MPLAYER_DEP_LIBS+=alsa-lib
-endif
-
$(DL_DIR)/$(MPLAYER_SOURCE):
$(WGET) -P $(DL_DIR) $(MPLAYER_SITE)/$(MPLAYER_SOURCE)
@@ -66,7 +60,7 @@
-$(STRIPCMD) $(STRIP_STRIP_UNNEEDED) $(TARGET_DIR)/$(MPLAYER_TARGET_BINARY)
touch -c $@
-mplayer: uclibc $(MPLAYER_DEP_LIBS) $(TARGET_DIR)/$(MPLAYER_TARGET_BINARY)
+mplayer: uclibc $(if $(BR2_PACKAGE_LIBMAD),libmad) $(if $(BR2_PACKAGE_ALSA_LIB),alsa-lib) $(TARGET_DIR)/$(MPLAYER_TARGET_BINARY)
mplayer-source: $(DL_DIR)/$(MPLAYER_SOURCE)
next reply other threads:[~2008-12-01 13:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-01 13:33 egtvedt at uclibc.org [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-01-26 9:22 [Buildroot] svn commit: trunk/buildroot/package/multimedia/mplayer jacmet at uclibc.org
2009-01-26 9:22 jacmet at uclibc.org
2009-01-27 0:52 ` Hamish Moffatt
2009-01-27 5:54 ` Peter Korsgaard
2009-01-27 12:58 ` Hamish Moffatt
2009-01-27 13:02 ` Peter Korsgaard
2009-01-28 0:13 ` Hamish Moffatt
2009-01-20 9:29 jacmet at uclibc.org
2009-01-20 9:12 jacmet at uclibc.org
2009-01-20 9:11 jacmet at uclibc.org
2009-01-20 6:17 egtvedt at uclibc.org
2008-12-04 16:49 egtvedt at uclibc.org
2008-12-01 13:08 egtvedt at uclibc.org
2008-12-01 12:53 egtvedt at uclibc.org
2008-12-01 12:48 egtvedt at uclibc.org
2008-12-01 12:32 egtvedt at uclibc.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081201133333.84D033C6F3@busybox.net \
--to=egtvedt@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox