From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
Date: Wed, 31 Dec 2008 18:28:28 +0100
Subject: [Buildroot] deprecated ustat() vs. statfs()
In-Reply-To: <495B8284.3080805@lbsd.net>
References: <495B8284.3080805@lbsd.net>
Message-ID: <20081231172828.GI8563@mx.loc>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

On Wed, Dec 31, 2008 at 02:32:36PM +0000, Nigel Kukard wrote:
>I dont suppose this is the correct way to switch to statfs()?

Switching to {f,}statfs is per se not really desirable.

quote from the manpage:
       LSB has deprecated the library calls statfs() and fstatfs()  and  tells
       us to use statvfs(2) and fstatvfs(2) instead.

statvfs is at least POSIX.

A simpler thing (i didn't look at the exact meaning of that function) may
be to just stat the path like e.g. the mountpoint applet ?) does.

HTH,
?) http://sources.busybox.net/index.py/trunk/busybox/miscutils/mountpoint.c?view=markup
>
>
>--- xfsprogs-2.10.2_vanilla/libxfs/linux.c    2008-12-09
>23:33:26.000000000 +0000
>+++ xfsprogs-2.10.2_remove-deprecated/libxfs/linux.c    2008-12-31
>14:30:45.000000000 +0000
>@@ -21,7 +21,7 @@
> #include <mntent.h>
> #include <sys/stat.h>
> #undef ustat
>-#include <sys/ustat.h>
>+#include <sys/statfs.h>
> #include <sys/mount.h>
> #include <sys/ioctl.h>
> #include <sys/sysinfo.h>
>@@ -49,7 +49,7 @@
> int
> platform_check_ismounted(char *name, char *block, struct stat64 *s, int
>verbose)
> {
>-    struct ustat    ust;
>+    struct statfs    ust;
>     struct stat64    st;
> 
>     if (!s) {
>@@ -60,7 +60,7 @@
>         s = &st;
>     }
> 
>-    if (ustat(s->st_rdev, &ust) >= 0) {
>+    if (statfs(s->st_rdev, &ust) >= 0) {
>         if (verbose)
>             fprintf(stderr,
>                 _("%s: %s contains a mounted filesystem\n"),
>