From: Markus Heidelberg <markus.heidelberg@web.de>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] Makefile: globally define variables used at different places
Date: Sun, 25 Jan 2009 18:36:48 +0100 [thread overview]
Message-ID: <200901251836.49104.markus.heidelberg@web.de> (raw)
$(comma) and $(space) are used in packages and the toolchain.
Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
---
Makefile | 5 +++++
package/directfb/directfb.mk | 6 ------
toolchain/gcc/gcc-uclibc-3.x.mk | 1 -
3 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/Makefile b/Makefile
index 6b12c76..a55d9bb 100644
--- a/Makefile
+++ b/Makefile
@@ -40,6 +40,11 @@ else
BR2_LOCAL:=$(TOPDIR)/local
endif
+# Variables for use in Make constructs
+comma:=,
+empty:=
+space:=$(empty) $(empty)
+
# $(shell find . -name *_defconfig |sed 's/.*\///')
# Pull in the user's configuration file
ifeq ($(filter $(noconfig_targets),$(MAKECMDGOALS)),)
diff --git a/package/directfb/directfb.mk b/package/directfb/directfb.mk
index cbf15bc..1aa38c7 100644
--- a/package/directfb/directfb.mk
+++ b/package/directfb/directfb.mk
@@ -52,9 +52,6 @@ endif
ifeq ($(DIRECTFB_GFX),)
DIRECTFB_GFX:=none
else
-comma:=,
-empty:=
-space:=$(empty) $(empty)
DIRECTFB_GFX:=$(subst $(space),$(comma),$(strip $(DIRECTFB_GFX)))
endif
@@ -75,9 +72,6 @@ endif
ifeq ($(DIRECTFB_INPUT),)
DIRECTFB_INPUT:=none
else
-comma:=,
-empty:=
-space:=$(empty) $(empty)
DIRECTFB_INPUT:=$(subst $(space),$(comma),$(strip $(DIRECTFB_INPUT)))
endif
diff --git a/toolchain/gcc/gcc-uclibc-3.x.mk b/toolchain/gcc/gcc-uclibc-3.x.mk
index fc59b6b..368ac8e 100644
--- a/toolchain/gcc/gcc-uclibc-3.x.mk
+++ b/toolchain/gcc/gcc-uclibc-3.x.mk
@@ -233,7 +233,6 @@ gcc_initial-dirclean:
# affect gcc-target. However, I haven't tested gcc-target yet so no
# guarantees. mjn3
-comma:=,
GCC_BUILD_DIR2:=$(TOOL_BUILD_DIR)/gcc-$(GCC_VERSION)-final
$(GCC_BUILD_DIR2)/.configured: $(GCC_DIR)/.patched $(GCC_STAGING_PREREQ)
mkdir -p $(GCC_BUILD_DIR2)
--
1.6.1.288.ga6efd
next reply other threads:[~2009-01-25 17:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-25 17:36 Markus Heidelberg [this message]
2009-01-25 20:16 ` [Buildroot] [PATCH 1/2] Makefile: globally define variables used at different places Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901251836.49104.markus.heidelberg@web.de \
--to=markus.heidelberg@web.de \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox