Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Hamish Moffatt <hamish@cloud.net.au>
To: buildroot@busybox.net
Subject: [Buildroot] RFC: option to Makefile.autotools.in to build in	$(PROJECT_BUILD_DIR)
Date: Fri, 20 Feb 2009 10:39:52 +1100	[thread overview]
Message-ID: <20090219233952.GA17913@cloud.net.au> (raw)
In-Reply-To: <87bpsya97p.fsf@macbook.be.48ers.dk>

On Thu, Feb 19, 2009 at 01:43:06PM +0100, Peter Korsgaard wrote:
> >>>>> "Bernhard" == Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> writes:
> 
> Hi,
> 
>  >> The target-specific-variable make feature is indeed usefull, but I
>  >> don't quite see how to apply it in this case.
> 
>  Bernhard> in this case just pickup an eventually given per-package
>  Bernhard> objdir instead of always using BUILD_DIR, perhaps something
>  Bernhard> like OBJDIR=$(if
>  Bernhard> $$($(2)_BUILDDIR),$$($(2)_BUILDDIR),$(BUILD_DIR))
> 
>  Bernhard> so you can just
>  Bernhard> package/foo/foo.mk:FOO_BUILDDIR=$(PROJECT_BUILDDIR)
>  Bernhard> (modulo typos)
> 
> That's pretty much what I suggested, but it doesn't remove the etra
> complexity to the Makefile.autotools.in rules (there's a generic set
> of rules going $(BUILD_DIR)/%/.stamp_<something>:). The package
> settings for the other things are done with ?= <default>, so adding a
> $(2)_BUILDDIR ?= $(BUILD_DIR) would be enough.

An alternative would be to move the rules within the macro expansion,
specifying exact filenames (via variable expansion) rather than using 
$(BUILD_DIR)/%/... That would be neater but would add a significant 
number of new rules (after expansion).


Hamish
-- 
Hamish Moffatt VK3SB <hamish@debian.org> <hamish@cloud.net.au>

      reply	other threads:[~2009-02-19 23:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-17  5:02 [Buildroot] RFC: option to Makefile.autotools.in to build in $(PROJECT_BUILD_DIR) Hamish Moffatt
2009-02-19 11:16 ` Peter Korsgaard
2009-02-19 11:33   ` Bernhard Reutner-Fischer
2009-02-19 12:14     ` Peter Korsgaard
2009-02-19 12:34       ` Bernhard Reutner-Fischer
2009-02-19 12:43         ` Peter Korsgaard
2009-02-19 23:39           ` Hamish Moffatt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090219233952.GA17913@cloud.net.au \
    --to=hamish@cloud.net.au \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox