From: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit] Fix memstat's install
Date: Wed, 22 Jul 2009 00:03:32 +0200 [thread overview]
Message-ID: <20090721220332.GJ14135@mx.loc> (raw)
In-Reply-To: <874ot5er9g.fsf@macbook.be.48ers.dk>
On Tue, Jul 21, 2009 at 10:05:15PM +0200, Peter Korsgaard wrote:
>>>>>> "Bernhard" == Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> writes:
>
>Hi,
>
>A bit more detailed changelog would be good.
Well, it does just that: Fix memstat's install stage (aka PR473) :)
> Bernhard> $(MEMSTAT_DIR)/memstat: $(MEMSTAT_DIR)/.configured
> Bernhard> - $(TARGET_CC) $(TARGET_CFLAGS) $(TARGET_LDFLAGS) $(@D)/memstat.c -o $@
> Bernhard> + $(TARGET_CC) $(TARGET_CFLAGS) $(TARGET_LDFLAGS) \
> Bernhard> + $(CFLAGS_WHOLE_PROGRAM) $(@D)/memstat.c -o $@
>
>What is this WHOLE_PROGRAM thing?
gcc --help=optimizers | grep whole-program
>
> Bernhard> $(TARGET_DIR)/usr/bin/memstat: $(MEMSTAT_DIR)/memstat
> Bernhard> [ -e $(TARGET_DIR)/etc/memstat.conf ] || \
> Bernhard> - $(INSTALL) -m 0644 -D $(^D)/memstat.conf $(TARGET_DIR)/etc
> Bernhard> + $(INSTALL) -m 0644 -D $(^D)/memstat.conf \
> Bernhard> + $(TARGET_DIR)/etc/memstat.conf
> Bernhard> $(INSTALL) -m 0755 -D $^ $@
> Bernhard> $(STRIPCMD) $(STRIP_STRIP_ALL) $@
>
> Bernhard> -memstat: uclibc $(TARGET_DIR)/usr/bin/memstat
> Bernhard> +memstat: $(TARGET_DIR)/usr/bin/memstat
>
>And why this unrelated change?
trivial cleanup while at it.
>
>Please post patches to the list before committing, thanks.
I accidentally committed it to the wrong repo, my apologies.
next prev parent reply other threads:[~2009-07-21 22:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-21 10:47 [Buildroot] [git commit] Fix memstat's install Bernhard Reutner-Fischer
2009-07-21 20:05 ` Peter Korsgaard
2009-07-21 22:03 ` Bernhard Reutner-Fischer [this message]
2009-07-22 6:01 ` Peter Korsgaard
2009-07-22 7:46 ` Bernhard Reutner-Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090721220332.GJ14135@mx.loc \
--to=rep.dot.nop@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox