Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Add sysstat tools
Date: Sun, 18 Oct 2009 17:47:32 +0200	[thread overview]
Message-ID: <20091018154732.GB13529@mx.loc> (raw)
In-Reply-To: <1255874745.19306.8.camel@coalu.atr>

On Sun, Oct 18, 2009 at 04:05:45PM +0200, Lionel Landwerlin wrote:
>ping ?
>
>Maybe I should add some informations about this package.
>
>The sysstat package provides a great tool named sar, which gives
>informations about cpu consumption in user/system context, as well as
>number of page faults per seconds, or number of blocks read from
>devices, etc...
>It's a good tool to tune performances on a system/cpu with software
>managed TLB (sh, mips or ppc).

>> --- /dev/null
>> +++ b/package/sysstat/Config.in
>> @@ -0,0 +1,7 @@
>> +config BR2_PACKAGE_SYSSTAT
>> +	bool "sysstat"
>> +	help
>> +	  System performance tools for the Linux operating system...

too many dots. Perhaps put your expanded description in here too.

>> diff --git a/package/sysstat/sysstat-9.0.5-Add-install-strip-rule.patch b/package/sysstat/sysstat-9.0.5-Add-install-strip-rule.patch
>> new file mode 100644
>> index 0000000..afe335f
>> --- /dev/null
>> +++ b/package/sysstat/sysstat-9.0.5-Add-install-strip-rule.patch

You sent this to upstream already, yes?

>> diff --git a/package/sysstat/sysstat.mk b/package/sysstat/sysstat.mk
>> new file mode 100644
>> index 0000000..cd8919f
>> --- /dev/null
>> +++ b/package/sysstat/sysstat.mk
>> @@ -0,0 +1,24 @@
>> +#############################################################
>> +#
>> +# sysstat
>> +#
>> +#############################################################
>> +
>> +SYSSTAT_VERSION = 9.0.5
>> +SYSSTAT_SOURCE = sysstat-$(SYSSTAT_VERSION).tar.bz2
>> +SYSSTAT_SITE = http://pagesperso-orange.fr/sebastien.godard/
>> +SYSSTAT_AUTORECONF = NO
>> +SYSSTAT_LIBTOOL_PATCH = NO
>> +SYSSTAT_INSTALL_STAGING = YES
>> +SYSSTAT_INSTALL_TARGET = YES
>> +
>> +SYSSTAT_DEPENDENCIES = uclibc

Every mention of uclibc as dependency of package/* is wrong (since
uclibc and the cross compiler et al are already deps for any target
package).
>> +
>> +# Should --disable-man-group ... WTF ?
>> +SYSSTAT_CONF_OPT = --enable-man-group
>> +
>> +EXPAT_INSTALL_TARGET_OPT = DESTDIR=$(TARGET_DIR) \
>> +			INSTALL_ISAG=n \
>> +			INSTALL_DOC=n

what's ISAG ?
INSTALL_DOC would be yes if BR2_HAVE_DOCUMENTATION.
$(if $(BR2_HAVE_DOCUMENTATION),,INSTALL_DOC=n)

thanks,

  reply	other threads:[~2009-10-18 15:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-09 13:48 [Buildroot] [PATCH] Add sysstat tools Lionel Landwerlin
2009-10-09 19:55 ` Lionel Landwerlin
2009-10-18 14:05   ` Lionel Landwerlin
2009-10-18 15:47     ` Bernhard Reutner-Fischer [this message]
2009-10-18 19:03       ` Lionel Landwerlin
2009-10-20 21:11         ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091018154732.GB13529@mx.loc \
    --to=rep.dot.nop@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox