Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Mack <daniel@caiaq.de>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] mtd-utils: bump version number
Date: Mon, 14 Dec 2009 18:49:35 +0800	[thread overview]
Message-ID: <20091214104935.GA28375@buzzloop.caiaq.de> (raw)
In-Reply-To: <87ljh5sx5r.fsf@macbook.be.48ers.dk>

On Mon, Dec 14, 2009 at 10:49:20AM +0100, Peter Korsgaard wrote:
> >>>>> "Daniel" == Daniel Mack <daniel@caiaq.de> writes:
> 
>  Daniel> The upstream git commit used by mtd.mk is not valid anymore,
>  Daniel> for unclear reasons. Use the current HEAD as new anchor.
> 
> Hmm, it works here:
> 
> wget --passive-ftp -nd   -O /var/lib/downloads/mtd-utils-fcb52ccc99679460640386c297023f852b108f68.tar.gz "http://git.infradead.org/mtd-utils.git?a=snapshot;h=fcb52ccc99679460640386c297023f852b108f68;sf=tgz"
> --2009-12-14 10:35:29--  http://git.infradead.org/mtd-utils.git?a=snapshot;h=fcb52ccc99679460640386c297023f852b108f68;sf=tgz
> Resolving git.infradead.org... 18.85.46.34, 2001:4830:2446:ff00:214:51ff:fe65:c65c
> 
> ls -lah mtd-utils-fcb52ccc99679460640386c297023f852b108f68.tar.gz
> -rw-r--r-- 1 peko peko 323K 2009-12-14 10:35 mtd-utils-fcb52ccc99679460640386c297023f852b108f68.tar.gz

Ok, the master branch moved forward and I recognized that too late,
hence the two patches.

> But the directory name has indeed changed.
> 
>  Daniel>  #############################################################
>  Daniel> -MTD_VERSION:=fcb52ccc99679460640386c297023f852b108f68
>  Daniel> +MTD_VERSION:=a4e502d99129da8ebba6d40b373a4422a175e9af
>  Daniel>  MTD_SOURCE:=mtd-utils-$(MTD_VERSION).tar.gz
>  Daniel>  MTD_URL:=http://git.infradead.org/mtd-utils.git?a=snapshot;h=$(MTD_VERSION);sf=tgz
>  Daniel>  MTD_HOST_DIR:= $(TOOLCHAIN_DIR)/mtd-utils-$(MTD_VERSION)
>  Daniel>  MTD_DIR:=$(BUILD_DIR)/mtd-utils-$(MTD_VERSION)
>  Daniel>  MTD_CAT:=$(ZCAT)
>  Daniel> -MTD_NAME:=mtd-utils
>  Daniel> +MTD_NAME:=mtd-utils-a4e502d
> 
> It would be nice if the shortname could be computed from MTD_VERSION so
> things don't break when someone goes and changes the git id. GNU make
> unfortunately doesn't have a substring function, so the easiest solution
> is probably cut, E.G.:

I though about that too, but I wasn't sure whether the substring of the
SHA1 ID would always be 7 characters long. I fear that is choses to be
as short as possible but as long as necessary to be unique. Which would
then mean that it changes again at an aribitrary point.

Best thing woulod be if the mtd people would just tag a commit with a
new release number. I'll write them and see if I can make them do that
:)

Daniel

  reply	other threads:[~2009-12-14 10:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-11 23:45 [Buildroot] [PATCH] mtd-utils: bump version number Daniel Mack
2009-12-11 23:55 ` Daniel Mack
2009-12-14  9:49   ` Peter Korsgaard
2009-12-14 10:49     ` Daniel Mack [this message]
2009-12-14 11:32       ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091214104935.GA28375@buzzloop.caiaq.de \
    --to=daniel@caiaq.de \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox