From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 08/10] external toolchain: fix strip of libraries
Date: Sat, 20 Feb 2010 16:20:06 +0100 [thread overview]
Message-ID: <20100220162006.4606227c@surf> (raw)
In-Reply-To: <1265561742-5924-9-git-send-email-llandwerlin@gmail.com>
This is needed and should be included in 2010.02.
Lionel, for your next patches, would it be possible to give a slightly
more detailed commit message ? Just "fix strip of libraries" is not
enough to understand what you are fixing, and therefore does not make
the review of your patches easy. Thanks! :-)
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
On Sun, 7 Feb 2010 17:55:40 +0100
llandwerlin at gmail.com wrote:
> From: Lionel Landwerlin <llandwerlin@gmail.com>
>
> Signed-off-by: Lionel Landwerlin <llandwerlin@gmail.com>
> ---
> toolchain/external-toolchain/ext-tool.mk | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/toolchain/external-toolchain/ext-tool.mk
> b/toolchain/external-toolchain/ext-tool.mk index 1f5aa19..39faf84
> 100644 --- a/toolchain/external-toolchain/ext-tool.mk
> +++ b/toolchain/external-toolchain/ext-tool.mk
> @@ -56,9 +56,9 @@ copy_toolchain_lib_root = \
> elif test -f $${LIB_DIR}/$${LIB}; then \
> $(INSTALL) -D -m0755
> $${LIB_DIR}/$${LIB} $(TARGET_DIR)$${DST}/$${LIB}; \ case "$${STRIP}"
> in \
> - (0 | n | no) \
> -;; \
> (*) \
> +;; \
> + (y) \
> $(TARGET_CROSS)strip
> "$(TARGET_DIR)$${DST}/$${LIB}"; \ ;; \
> esac; \
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2010-02-20 15:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-07 16:55 [Buildroot] [PATCH 00/10] Pull-request: A few fixes and conversions to new package infrastructure llandwerlin at gmail.com
2010-02-07 16:55 ` [Buildroot] [PATCH 01/10] ncurses: convert to autotools infrastructure llandwerlin at gmail.com
2010-02-07 16:55 ` [Buildroot] [PATCH 02/10] ncurses: fix path to patch ncurses5-config llandwerlin at gmail.com
2010-02-07 16:55 ` [Buildroot] [PATCH 03/10] lua: conversion to new package infrastructure llandwerlin at gmail.com
2010-02-09 13:59 ` Gustavo Zacarias
2010-02-07 16:55 ` [Buildroot] [PATCH 04/10] package: Add $(HOST_DIR)/usr/lib to LD_LIBRARY_PATH for make & configure env variables llandwerlin at gmail.com
2010-02-07 16:55 ` [Buildroot] [PATCH 05/10] Rework icu package on top of the generic infrastructure llandwerlin at gmail.com
2010-02-07 16:55 ` [Buildroot] [PATCH 06/10] package: Added post uninstall hooks llandwerlin at gmail.com
2010-02-07 16:55 ` [Buildroot] [PATCH 07/10] package: fix install without strip llandwerlin at gmail.com
2010-02-08 13:42 ` Paulius Zaleckas
2010-02-07 16:55 ` [Buildroot] [PATCH 08/10] external toolchain: fix strip of libraries llandwerlin at gmail.com
2010-02-20 15:20 ` Thomas Petazzoni [this message]
2010-02-20 16:58 ` Lionel Landwerlin
2010-02-07 16:55 ` [Buildroot] [PATCH 09/10] ext-toolchain: remove pkgconfig files from the external toolchain llandwerlin at gmail.com
2010-02-07 16:55 ` [Buildroot] [PATCH 10/10] scripts: force copy of files to erase already present and readonly files llandwerlin at gmail.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100220162006.4606227c@surf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox