From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] pciutils: convert to the autotools infrastructure
Date: Wed, 14 Apr 2010 15:10:35 +0200 [thread overview]
Message-ID: <20100414151035.66ce8e50@surf> (raw)
In-Reply-To: <78409DB4-3D71-4100-81B8-653F239F8E31@me.com>
Hello,
Thanks for doing this! A couple of comments below.
On Tue, 13 Apr 2010 23:49:17 +0200
Thomas Brandstetter <thomas.brandstetter@me.com> wrote:
> +PCIUTILS_CONFIGURE_CMDS = echo ""
pciutils build system is not based on the autotools, therefore, you
should not be using the autotools infrastructure, but the generic
infrastructure (i.e GENTARGETS instead of AUTOTARGETS).
See http://buildroot.org/downloads/buildroot.html#generic-tutorial for
details.
> +$(PCIUTILS_HOOK_POST_EXTRACT):
> $(SED) 's/uname -s/echo Linux/' \
> -e 's/uname -r/echo $(LINUX_HEADERS_VERSION)/' \
> - $(PCIUTILS_DIR)/lib/configure
> + $(PCIUTILS_DIR)/lib/configure
Could you use the new style hooks instead ? See again above link for
details.
> +$(PCIUTILS_HOOK_POST_INSTALL):
> + $(STRIPCMD) $(TARGET_DIR)/usr/sbin/lspci
> + $(STRIPCMD) $(TARGET_DIR)/usr/sbin/setpci
This is not needed, binaries in $(TARGET_DIR) are automatically
stripped.
Regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
prev parent reply other threads:[~2010-04-14 13:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-13 21:49 [Buildroot] [PATCH] pciutils: convert to the autotools infrastructure Thomas Brandstetter
2010-04-14 10:31 ` Peter Korsgaard
2010-04-14 13:10 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100414151035.66ce8e50@surf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox