Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] Question about external toolchain configuration "options"
Date: Wed, 14 Apr 2010 16:58:37 +0200	[thread overview]
Message-ID: <20100414165837.453af3a1@surf> (raw)
In-Reply-To: <201004132051.48176.yann.morin.1998@anciens.enib.fr>

On Tue, 13 Apr 2010 20:51:47 +0200
"Yann E. MORIN" <yann.morin.1998@anciens.enib.fr> wrote:

> To determine these 'options', we need to know the external toolchain location
> first. The external toolchain location is also specified in the menuconfig.
> 
> So there is no way to detect those values, and properly show/hide the
> affected packages.

Right.

> Then there is two solutions:
> - present toolchain 'options', and have proper package hidding, but implies
>   checking the user did not make a mistake in the toolchain 'options',
> or:
> - present all packages, and then check that selected packages are buildable.
> 
> buildroot choosed the first solution. It has the advantage of using the
> same package dependency rules as when using the built-in toolchain mechanism.

Exactly.

> Maybe the prompts should be reworked with smthg like (when external toolchain
> is selected):
>   [ ] Toolchain has IPv6
>   [ ] Toolchain has locales
> and so on...

This is what my toolchain-config-improvements branch does
(http://git.buildroot.net/~tpetazzoni/git/buildroot/log/?h=toolchain-config-improvements),
but Peter had comments when I submitted it and I have ideas for
improvements.

I think I'll use some hidden options like :

config BR2_TOOLCHAIN_HAS_IPV6
	bool

All the packages should depend o n BR2_TOOLCHAIN_HAS_* options. And
then, internal toolchains configuration would do something like:

config BR2_BUILDROOT_TOOLCHAIN_ENABLE_IPV6
	bool "Enable IPv6 support"
	select BR2_TOOLCHAIN_HAS_IPV6

while external toolchain configuration would do something like:

config BR2_EXTERNAL_TOOLCHAIN_HAS_IPV6
	bool "Toolchain has IPv6"
	select BR2_TOOLCHAIN_HAS_IPV6

What do you think of this ?

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2010-04-14 14:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-13 18:30 [Buildroot] Question about external toolchain configuration "options" Grant Edwards
2010-04-13 18:51 ` Yann E. MORIN
2010-04-14 14:58   ` Thomas Petazzoni [this message]
2010-04-14 15:01     ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100414165837.453af3a1@surf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox