Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit master] file: bump version and migrate to autotargets
Date: Wed, 9 Jun 2010 08:35:20 +0200	[thread overview]
Message-ID: <20100609083520.09d5f9b2@surf> (raw)
In-Reply-To: <20100608220138.82FF1909FC@busybox.osuosl.org>

Hello,

On Tue, 8 Jun 2010 23:32:40 +0200
Gustavo Zacarias <gustavo@zacarias.com.ar> wrote:

> +$(FILE_TARGET_UNINSTALL):
> +	$(call MESSAGE,"Uninstalling")
> +	$(MAKE) DESTDIR=$(TARGET_DIR) uninstall -C $(FILE_DIR)
> +	rm -f $(TARGET_DIR)/usr/lib/libmagic.*
> +	rm -f $(FILE_TARGET_INSTALL_TARGET) $(FILE_HOOK_POST_INSTALL)

Ah, I didn't catch this at the review phase. I'd like to get rid of
these ? old style ? way of overloading operations. You can do the same
in a new style way with:

define FILE_UNINSTALL_TARGET_CMDS
	$(MAKE) DESTDIR=$(TARGET_DIR) uninstall -C $(@D)
	rm -f $(TARGET_DIR)/usr/lib/libmagic.*
endef

Thanks,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2010-06-09  6:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-08 21:32 [Buildroot] [git commit master] file: bump version and migrate to autotargets Gustavo Zacarias
2010-06-09  6:35 ` Thomas Petazzoni [this message]
2010-06-09  6:54   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100609083520.09d5f9b2@surf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox