Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Fixed LINUX26_IMAGE_PATH
Date: Wed, 30 Jun 2010 14:03:55 +0200	[thread overview]
Message-ID: <20100630140355.7fddbd22@surf> (raw)
In-Reply-To: <1277894627-4586-1-git-send-email-henuxd@gmail.com>

Hello Henri,

I've seen your message on IRC, but you left too early for me to react
on your question.

On Wed, 30 Jun 2010 13:43:47 +0300
Henri H?kkinen <henuxd@gmail.com> wrote:

> Kernel image is actually located in boot/images/ rather than in boot/
> ---
>  linux/linux.mk |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/linux/linux.mk b/linux/linux.mk
> index 593a1b4..355276e 100644
> --- a/linux/linux.mk
> +++ b/linux/linux.mk
> @@ -42,7 +42,7 @@ else ifeq ($(BR2_LINUX_KERNEL_VMLINUX),y)
>  LINUX26_IMAGE_NAME=vmlinux.bin
>  endif
>  
> -LINUX26_IMAGE_PATH=$(LINUX26_DIR)/arch/$(KERNEL_ARCH)/boot/$(LINUX26_IMAGE_NAME)
> +LINUX26_IMAGE_PATH=$(LINUX26_DIR)/arch/$(KERNEL_ARCH)/boot/images/$(LINUX26_IMAGE_NAME)

This will break ARM/x86 and many other architectures. Instead, we
probably need something like:

ifeq ($(KERNEL_ARCH),avr32)
LINUX26_IMAGE_PATH=$(LINUX26_DIR)/arch/$(KERNEL_ARCH)/boot/images/$(LINUX26_IMAGE_NAME)
else
LINUX26_IMAGE_PATH=$(LINUX26_DIR)/arch/$(KERNEL_ARCH)/boot/$(LINUX26_IMAGE_NAME)
endif

Regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  parent reply	other threads:[~2010-06-30 12:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-30 10:43 [Buildroot] [PATCH] Fixed LINUX26_IMAGE_PATH Henri Häkkinen
2010-06-30 10:59 ` Baruch Siach
2010-06-30 12:03 ` Thomas Petazzoni [this message]
2010-06-30 13:17   ` Thiago A. Corrêa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100630140355.7fddbd22@surf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox