From: Malte Starostik <m-starostik@versanet.de>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Purge libglib2 dev files from target
Date: Sat, 24 Jul 2010 13:19:49 +0200 [thread overview]
Message-ID: <201007241319.49745.m-starostik@versanet.de> (raw)
In-Reply-To: <1279936004.30974.17.camel@coalu.atr>
Am Samstag, 24. Juli 2010, 03:46:44 schrieb Lionel Landwerlin:
> Le jeudi 22 juillet 2010 ? 11:03 +0200, Malte Starostik a ?crit :
> > * Don't install libglib2 development binaries and to target unless
> >
> > BR2_HAVE_DEVFILES is set
> >
> > * Don't install gdb plugins unless BR2_TARGET_GDB is set
> > * Remove $(TARGET_DIR)/usr/share/aclocal from target-finalize when not
> >
> > installing devfiles
> >
> > * Same for /usr/share/gdb in the absence of BR2_TARGET_GDB
> > * Remove some redundant cleanup from individual packages
> >
> > Signed-off-by: Malte Starostik <m-starostik@versanet.de>
>
> Maybe you can split your patch in two. One part which would be related
> to strip the debug files, the second would be related to strip dev files
> (aclocal directories).
New patch follows. Actually I split it into three to separate the devfiles
part into a global and a libglib2 specific part.
>
> > +
> > +define LIBGLIB2_REMOVE_GDB_FILES
> > + rm -rf $(TARGET_DIR)/usr/share/glib-2.0/gdb
> > + rmdir --ignore-fail-on-non-empty $(TARGET_DIR)/usr/share/glib-2.0
> > +endef
> > +
>
> Why using rmdir ? rm -rf isn't good enough ?
Unset BR2_HAVE_DEVFILES => rm -rf $(TARGET_DIR)/usr/share/glib-2.0/gettext
Unset BR2_TARGET_GDB => rm -rf $(TARGET_DIR)/usr/share/glib-2.0/gdb
Both unset => rmdir the parent, too
>
> Otherwise looks good ! :)
Thanks :)
Malte
next prev parent reply other threads:[~2010-07-24 11:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-22 8:59 [Buildroot] [PATCH] Purge libglib2 dev files from target Malte Starostik
2010-07-24 1:46 ` Lionel Landwerlin
2010-07-24 11:19 ` Malte Starostik [this message]
2010-07-24 11:21 ` [Buildroot] [PATCH 1/3] Globally remove aclocal directories " Malte Starostik
2010-07-24 17:56 ` Thomas Petazzoni
2010-07-30 8:45 ` Peter Korsgaard
2010-07-24 11:21 ` [Buildroot] [PATCH 2/3] Purge libglib2 dev files " Malte Starostik
2010-07-24 17:59 ` Thomas Petazzoni
2010-07-30 8:44 ` Peter Korsgaard
2010-07-24 11:21 ` [Buildroot] [PATCH 3/3] Remove gdb plugins " Malte Starostik
2010-07-24 17:58 ` Thomas Petazzoni
2010-07-24 19:29 ` [Buildroot] [Corrected - my bad][PATCH] " Malte Starostik
2010-07-30 8:47 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007241319.49745.m-starostik@versanet.de \
--to=m-starostik@versanet.de \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox