From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Add xorg support and upgrade for mp3 issue.
Date: Sun, 22 Aug 2010 12:57:40 +0200 [thread overview]
Message-ID: <20100822125740.3f3bdea1@surf> (raw)
In-Reply-To: <1282404097-12535-1-git-send-email-max@marretta.com>
Hello Massimiliano,
Thanks for reworking the patch with Git. I have a couple of comments,
though. First, does the X.org support needs to be part of the same
patch as the version bump ? In other words, shouldn't this be split in
several smaller patches (one to bump the versions, one to add X.org
support) ?
It would be good to add a little bit more details in the commit log:
what does the X.org support brings, and what mp3 issue is being fixed
by the version bump ?
Other comments below.
On Sat, 21 Aug 2010 17:21:37 +0200
Massimiliano Marretta <max@marretta.com> wrote:
> GST_PLUGINS_BASE_CONF_OPT = \
> --disable-examples \
> - --disable-x \
> - --disable-xvideo \
> - --disable-xshm \
> --disable-oggtest \
> --disable-vorbistest \
> --disable-freetypetest
>
> +
> +
> +
Useless newlines. Keep only one.
> +ifeq ($(BR2_PACKAGE_XORG7),y)
> +GST_PLUGINS_BASE_DEPENDENCIES += xserver_xorg-server
> +GST_PLUGINS_BASE_CONF_OPT += --enable-x \
> + --enable-xvideo \
> + --enable-xshm
> +else
> +GST_PLUGINS_BASE_CONF_OPT += --disable-x \
> + --disable-xvideo \
> + --disable-xshm
> +endif
This is really a detail, but I'd prefer to have the first --option on a
newline, so :
GST_PLUGINS_BASE_CONF_OPT += \
--disable-foobar \
--disable-barfoo
> +ifeq ($(BR2_PACKAGE_XORG7),y)
> +GST_PLUGINS_BASE_DEPENDENCIES += xserver_xorg-server
> +GST_PLUGINS_BASE_CONF_OPT += --enable-x \
> + --enable-x \
Duplicate.
> + --enable-xvideo \
> + --enable-xshm
> +else
> +GST_PLUGINS_BASE_CONF_OPT += --disable-x \
> + --disable-x \
Duplicate again.
> + --disable-xvideo \
> + --disable-xshm
> +endif
> --- a/package/multimedia/gstreamer/gstreamer-0.10.25-fix-unaligned-detectiob-for-x86-64.patch
> +++ /dev/null
Are you sure this patch is no longer needed ?
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2010-08-22 10:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-21 15:21 [Buildroot] [PATCH] Add xorg support and upgrade for mp3 issue Massimiliano Marretta
2010-08-22 10:57 ` Thomas Petazzoni [this message]
2010-08-27 10:14 ` Sven Neumann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100822125740.3f3bdea1@surf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox