From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 18/21] ntp: convert to autotargets and bump to 4.2.6p2
Date: Sat, 18 Sep 2010 19:19:44 +0200 [thread overview]
Message-ID: <20100918191944.612fee30@surf> (raw)
In-Reply-To: <1284435648-15238-18-git-send-email-Martin.Banky@gmail.com>
Hello !
On Mon, 13 Sep 2010 20:40:45 -0700
Martin Banky <martin.banky@gmail.com> wrote:
> +config BR2_PACKAGE_NTP_NTP-KEYGEN
Please don't use the dash character in configuration options. This
should be BR2_PACKAGE_NTP_KEYGEN or BR2_PACKAGE_NTP_NTP_KEYGEN.
> +NTP_DIR = $(BUILD_DIR)/ntp-$(NTP_VERSION)
Not needed.
> +NTP_CAT = $(ZCAT)
Not needed.
> ifeq ($(BR2_PACKAGE_NTP_SNTP),y)
> +define NTP_INSTALL_SNTP
> install -m 755 $(NTP_DIR)/sntp/sntp $(TARGET_DIR)/usr/bin/sntp
> +endef
> +endif
Instead of $(NTP_DIR), use $(@D).
> +
> +ifeq ($(BR2_PACKAGE_NTP_NTP-KEYGEN),y)
> +define NTP_INSTALL_NTP-KEYGEN
> + install -m 755 $(NTP_DIR)/util/ntp-keygen $(TARGET_DIR)/usr/bin/ntp-keygen
> +endef
> +endif
> +
> +ifeq ($(BR2_PACKAGE_NTP_NTP-WAIT),y)
> +define NTP_INSTALL_NTP-WAIT
> + install -m 755 $(NTP_DIR)/scripts/ntp-wait $(TARGET_DIR)/usr/bin/ntp-wait
> +endef
> +endif
> +
> +ifeq ($(BR2_PACKAGE_NTP_NTPDC),y)
> +define NTP_INSTALL_NTPDC
> + install -m 755 $(NTP_DIR)/ntpdc/ntpdc $(TARGET_DIR)/usr/bin/ntpdc
> +endef
> +endif
> +
> +ifeq ($(BR2_PACKAGE_NTP_NTPQ),y)
> +define NTP_INSTALL_NTPQ
> + install -m 755 $(NTP_DIR)/ntpq/ntpq $(TARGET_DIR)/usr/bin/ntpq
> +endef
> +endif
> +
> +ifeq ($(BR2_PACKAGE_NTP_NTPTRACE),y)
> +define NTP_INSTALL_NTPTRACE
> + install -m 755 $(NTP_DIR)/scripts/ntptrace $(TARGET_DIR)/usr/bin/ntptrace
> +endef
> +endif
> +
> +ifeq ($(BR2_PACKAGE_NTP_TICKADJ),y)
> +define NTP_INSTALL_TICKADJ
> + install -m 755 $(NTP_DIR)/util/tickadj $(TARGET_DIR)/usr/bin/tickadj
> +endef
> endif
> +
> +define NTP_INSTALL_TARGET_CMDS
> + install -m 755 $(NTP_DIR)/ntpd/ntpd $(TARGET_DIR)/usr/sbin/ntpd
> + $(NTP_INSTALL_SNTP)
> + $(NTP_INSTALL_NTP-KEYGEN)
> + $(NTP_INSTALL_NTP-WAIT)
> + $(NTP_INSTALL_NTPDC)
> + $(NTP_INSTALL_NTPQ)
> + $(NTP_INSTALL_NTPTRACE)
> + $(NTP_INSTALL_TICKADJ)
Humm, you could rewrite this this way:
NTP_INSTALL_BIN_FILES =
ifeq ($(BR2_PACKAGE_NTP_NTP_KEYGEN),y)
NTP_INSTALL_BIN_FILES += util/ntp-keygen
endif
ifeq ($(BR2_PACKAGE_NTP_NTP-WAIT),y)
NTP_INSTALL_BIN_FILES += scripts/ntp-wait
endif
...
and then :
define NTP_INSTALL_TARGET_CMDS
install -m 755 $(NTP_DIR)/ntpd/ntpd $(TARGET_DIR)/usr/sbin/ntpd
test -z "$(NTP_INSTALL_BIN_FILES)" || install -m 755 $(addprefix $(@D),$(NTP_INSTALL_BIN_FILES)) $(TARGET_DIR)/usr/bin/
endif
and finally :
define NTP_UNINSTALL_TARGET_CMDS
rm -f $(addprefix $(TARGET_DIR)/usr/bin/,$(NTP_INSTALL_BIN_FILES))
endif
Regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2010-09-18 17:19 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-14 3:40 [Buildroot] [PATCH 01/21] alsa-lib: bump to 1.0.23 Martin Banky
2010-09-14 3:40 ` [Buildroot] [PATCH 02/21] alsa-utils: " Martin Banky
2010-09-14 3:40 ` [Buildroot] [PATCH 03/21] autoconf: bump to 2.67 Martin Banky
2010-09-14 3:40 ` [Buildroot] [PATCH 04/21] automake: bump to 1.11.1 Martin Banky
2010-09-14 8:51 ` Lionel Landwerlin
2010-09-15 2:58 ` Martin Banky
2010-09-15 9:10 ` Lionel Landwerlin
2010-09-15 10:13 ` Martin Banky
2010-09-14 3:40 ` [Buildroot] [PATCH 05/21] bison: bump to 2.4.3 Martin Banky
2010-09-18 17:02 ` Thomas Petazzoni
2010-09-18 21:36 ` Martin Banky
2010-09-14 3:40 ` [Buildroot] [PATCH 06/21] ccache: bump to 3.0.1 Martin Banky
2010-09-14 3:40 ` [Buildroot] [PATCH 07/21] fakeroot: bump to 1.14.4 Martin Banky
2010-09-14 3:40 ` [Buildroot] [PATCH 08/21] genext2fs: bump to 1.4.1 Martin Banky
2010-09-14 3:40 ` [Buildroot] [PATCH 09/21] gmp: bump to 5.0.1 Martin Banky
2010-09-18 17:03 ` Thomas Petazzoni
2010-09-19 0:35 ` Martin Banky
2010-09-14 3:40 ` [Buildroot] [PATCH 10/21] libdeamon: bump to 0.14 Martin Banky
2010-09-14 3:40 ` [Buildroot] [PATCH 11/21] libelf: bump to 0.8.13 Martin Banky
2010-09-14 3:40 ` [Buildroot] [PATCH 12/21] libogg: bump to 1.2.0 Martin Banky
2010-09-14 3:40 ` [Buildroot] [PATCH 13/21] libvorbis: bump to 1.3.1 Martin Banky
2010-09-14 3:40 ` [Buildroot] [PATCH 14/21] make: bump to 3.82 Martin Banky
2010-09-14 3:40 ` [Buildroot] [PATCH 15/21] module-init-tools: bump to 3.12 Martin Banky
2010-09-14 3:40 ` [Buildroot] [PATCH 16/21] mpfr: bump to 3.0.0 Martin Banky
2010-09-14 3:40 ` [Buildroot] [PATCH 17/21] nano: bump to 2.2.5 Martin Banky
2010-09-14 3:40 ` [Buildroot] [PATCH 18/21] ntp: convert to autotargets and bump to 4.2.6p2 Martin Banky
2010-09-18 17:19 ` Thomas Petazzoni [this message]
2010-09-21 17:39 ` Martin Banky
2010-09-14 3:40 ` [Buildroot] [PATCH 19/21] openssl: bump to 1.0.0a Martin Banky
2010-09-14 3:40 ` [Buildroot] [PATCH 20/21] BugFix - Bison - Fixed Missing stddef.h Include In wchar.h Martin Banky
2010-09-14 19:54 ` Thomas Petazzoni
2010-09-15 1:45 ` Martin Banky
2010-09-14 3:40 ` [Buildroot] [PATCH 21/21] BugFix - m4 - Fixed Missing wint_t typedef When There Is No WChar Support Martin Banky
2010-09-19 20:45 ` Peter Korsgaard
2010-09-20 0:37 ` Martin Banky
2010-09-18 17:00 ` [Buildroot] [PATCH 01/21] alsa-lib: bump to 1.0.23 Thomas Petazzoni
2010-09-18 20:54 ` Martin Banky
-- strict thread matches above, loose matches on Subject: below --
2010-09-19 2:53 [Buildroot] [PATCH 00/21] Resend package updates patch set Martin Banky
2010-09-19 2:53 ` [Buildroot] [PATCH 18/21] ntp: convert to autotargets and bump to 4.2.6p2 Martin Banky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100918191944.612fee30@surf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox