Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/6] coreutils: converted to autotarget
Date: Wed, 29 Sep 2010 13:23:54 +0200	[thread overview]
Message-ID: <20100929132354.69c0efed@surf> (raw)
In-Reply-To: <1285296904-25793-1-git-send-email-Martin.Banky@gmail.com>

Hello Martin,

On Thu, 23 Sep 2010 19:54:59 -0700
Martin Banky <martin.banky@gmail.com> wrote:

> +#COREUTILS_SITE = ftp://alpha.gnu.org/gnu/coreutils/

Remove this line.

> +BIN_PROGS = cat chgrp chmod chown cp date dd df dir echo false hostname \
> +	ln ls mkdir mknod mv pwd rm rmdir vdir sleep stty sync touch true \
> +	uname join

The variable namespace is completely global in Buildroot, so I'd prefer
to see this variable prefixed with COREUTILS_

> +ifneq ($(BR2_ENABLE_LOCALE),y)
> +define COREUTILS_REMOVE_LOCALE
> +	rm -rf $(TARGET_DIR)/share/locale
> +endef
> +COREUTILS_POST_INSTALL_TARGET_HOOKS += COREUTILS_REMOVE_LOCALE

Not needed, the top-level Makefile takes care of this.

Thanks!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  parent reply	other threads:[~2010-09-29 11:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-24  2:54 [Buildroot] [PATCH 1/6] coreutils: converted to autotarget Martin Banky
2010-09-24  2:55 ` [Buildroot] [PATCH 2/6] coreutils: changed/removed some of the configure environmental variables Martin Banky
2010-09-24  2:55 ` [Buildroot] [PATCH 3/6] coreutils: fixed missing hostname Martin Banky
2010-09-24  2:55 ` [Buildroot] [PATCH 4/6] coreutils: bump to 8.5 Martin Banky
2010-09-24  2:55 ` [Buildroot] [PATCH 5/6] coreutils: changed/removed some of the configure environmental variables Martin Banky
2010-09-24  2:55 ` [Buildroot] [PATCH 6/6] coreutils: add uname patch Martin Banky
2010-09-29 11:23 ` Thomas Petazzoni [this message]
2010-09-29 20:18   ` [Buildroot] [PATCH 1/6] coreutils: converted to autotarget Martin Banky
  -- strict thread matches above, loose matches on Subject: below --
2010-09-30 19:03 [Buildroot] [PATCH 0/6] Resubmit coreutils patchset Martin Banky
2010-09-30 19:03 ` [Buildroot] [PATCH 1/6] coreutils: converted to autotarget Martin Banky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100929132354.69c0efed@surf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox