From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 02/12] rsync: drop special case now managed in Makefile.package.in
Date: Thu, 4 Nov 2010 14:38:39 +0100 [thread overview]
Message-ID: <20101104143839.10843e5f@surf> (raw)
In-Reply-To: <1288839031-24277-3-git-send-email-llandwerlin@gmail.com>
Hello,
On Thu, 4 Nov 2010 03:50:21 +0100
llandwerlin at gmail.com wrote:
> -RSYNC_CONF_OPT=$(if $(BR2_ENABLE_DEBUG),--enable-debug,--disable-debug)
As far as I can see, passing --{enable,disable}-debug is not handled by
the autotools infrastructure. Maybe those are not needed, but this
change is not transparent.
> -ifeq ($(BR2_ENABLE_DEBUG),y)
> -RSYNC_INSTALL_TARGET_OPT:=DESTDIR=$(TARGET_DIR) INSTALLCMD='./install-sh -c' \
> - install
> -else
> -RSYNC_INSTALL_TARGET_OPT:=DESTDIR=$(TARGET_DIR) INSTALLCMD='./install-sh -c' \
> - STRIPPROG="$(TARGET_STRIP)" install-strip
> -endif
> +
> +RSYNC_MAKE_ENV = STRIPPROG="$(STRIPCMD)"
The autotools infrastructure no longer uses the "install-strip" target.
So is this still useful ?
Other question: the autotools infrastructure does not pass INSTALLCMD.
If it's really needed by this package, then this patch will break the
package.
Regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2010-11-04 13:38 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-04 2:50 [Buildroot] [pull request] Pull request for branch 2010.11-various-bumps llandwerlin at gmail.com
2010-11-04 2:50 ` [Buildroot] [PATCH 01/12] sh: add /dev/ttyASx console devices llandwerlin at gmail.com
2010-11-04 13:33 ` Thomas Petazzoni
2010-11-04 13:38 ` Lionel Landwerlin
2010-11-04 2:50 ` [Buildroot] [PATCH 02/12] rsync: drop special case now managed in Makefile.package.in llandwerlin at gmail.com
2010-11-04 13:38 ` Thomas Petazzoni [this message]
2010-11-04 2:50 ` [Buildroot] [PATCH 03/12] autotools: fix MESSAGE calls llandwerlin at gmail.com
2010-11-04 13:39 ` Thomas Petazzoni
2010-11-05 8:48 ` Peter Korsgaard
2010-11-04 2:50 ` [Buildroot] [PATCH 04/12] autotools: introduce $(PKG_NAME)_AUTORECONF_ENV/$(PKG_NAME)_AUTORECONF_OPT variables llandwerlin at gmail.com
2010-11-04 13:44 ` Thomas Petazzoni
2010-11-04 13:49 ` Lionel Landwerlin
2010-11-04 15:30 ` Thomas Petazzoni
2010-11-04 2:50 ` [Buildroot] [PATCH 05/12] package: move autoreconfigure step to pre configure hook llandwerlin at gmail.com
2010-11-04 13:45 ` Thomas Petazzoni
2010-11-05 9:04 ` Peter Korsgaard
2010-11-04 2:50 ` [Buildroot] [PATCH 06/12] gdk-pixbuf/libgtk2: move gdk-pixbuf loader cache setup script llandwerlin at gmail.com
2010-11-04 8:10 ` Paulius Zaleckas
2010-11-04 8:21 ` Lionel Landwerlin
2010-11-04 13:46 ` Thomas Petazzoni
2010-11-05 9:07 ` Peter Korsgaard
2010-11-04 2:50 ` [Buildroot] [PATCH 07/12] automake: bump to 1.11.1 llandwerlin at gmail.com
2010-11-04 13:48 ` Thomas Petazzoni
2010-11-05 8:49 ` Peter Korsgaard
2010-11-04 2:50 ` [Buildroot] [PATCH 08/12] sysstat: bump to 9.1.5 llandwerlin at gmail.com
2010-11-05 9:09 ` Peter Korsgaard
2010-11-04 2:50 ` [Buildroot] [PATCH 09/12] libpcap: bump to 1.1.1 llandwerlin at gmail.com
2010-11-05 8:52 ` Peter Korsgaard
2010-11-04 2:50 ` [Buildroot] [PATCH 10/12] linux-fusion: bump to 8.1.2 llandwerlin at gmail.com
2010-11-05 9:11 ` Peter Korsgaard
2010-11-04 2:50 ` [Buildroot] [PATCH 11/12] directfb: bump to 1.4.10 llandwerlin at gmail.com
2010-11-05 9:13 ` Peter Korsgaard
2010-11-05 12:52 ` Peter Korsgaard
2010-11-05 13:30 ` Lionel Landwerlin
2010-11-05 14:00 ` Peter Korsgaard
2010-11-04 2:50 ` [Buildroot] [PATCH 12/12] sawman: " llandwerlin at gmail.com
2010-11-05 9:14 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101104143839.10843e5f@surf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox