From: Mike Frysinger <vapier@gentoo.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] rsh-redone: new package for rsh/rlogin clients
Date: Tue, 7 Dec 2010 16:30:31 -0500 [thread overview]
Message-ID: <201012071630.31741.vapier@gentoo.org> (raw)
In-Reply-To: <87ei9ts2jk.fsf@macbook.be.48ers.dk>
On Tuesday, December 07, 2010 16:20:31 Peter Korsgaard wrote:
> >> Does this do anything else than just copying the binaries? If not, it
> >> might be simpler to just do a
> >>
> >> for i in $(rsh-redone-bin-y); do $(INSTALL) -m 755 -D $$i
> >> $(TARGET_DIR)/usr/bin/$$i; done for i in $(rsh-redone-sbin-y); do
> >> $(INSTALL) -m 755 -D $$i $(TARGET_DIR)/usr/sbin/$$i; done
>
> Mike> i prefer to let the package build system do these simple steps to
> Mike> avoid worrying about changes in between version bumps. this
> Mike> proposal for examples misses set*id on the binaries, and i'm not
> Mike> entirely sure it is more simple.
>
> setuid/setgid wouldn't work anyway, as we don't do make install as
> root. For that kind of stuff you have to define it in device_table.txt
> like it's done for busybox.
sounds like a limitation in the build system somewhere. the file is certainly
installed into output/target/ with set*id.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20101207/83f3f9b1/attachment-0001.pgp>
next prev parent reply other threads:[~2010-12-07 21:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 23:20 [Buildroot] [PATCH] rsh-redone: new package for rsh/rlogin clients Mike Frysinger
2010-11-19 5:40 ` [Buildroot] [PATCH v2] " Mike Frysinger
2010-12-07 11:07 ` Peter Korsgaard
2010-12-07 20:54 ` Mike Frysinger
2010-12-07 21:20 ` Peter Korsgaard
2010-12-07 21:30 ` Mike Frysinger [this message]
2010-12-07 21:03 ` [Buildroot] [PATCH v3] " Mike Frysinger
2010-12-08 22:32 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201012071630.31741.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox