From: Mike Frysinger <vapier@gentoo.org>
To: buildroot@busybox.net
Subject: [Buildroot] helper tool handling in build system (sed/install/...)
Date: Wed, 8 Dec 2010 03:50:45 -0500 [thread overview]
Message-ID: <201012080350.46424.vapier@gentoo.org> (raw)
i cant seem to figure out why we bother looking up the full path:
SED:=$(shell which sed || type -p sed) -i -e
we dont build up host versions, nor do we have to worry about them being found
in the cross-compiled PATH since we arent adding that to the host PATH. the
only things this which/type logic is doing is shortcutting the shell's
implicit PATH lookup -- which is pretty much useless since it isnt saving us
any forks. if anything, it just adds shell overhead whenever someone does
`make` because of the usage of ":=".
further, it isnt like we're trying to be portable. the sed's -i usage is
purely GNU and not POSIX compliant at all. which makes me wonder why the -e
is even there since the default behavior of `sed` is to treat the first
argument as a script. and then makes me wonder why we have $(SED) at all --
there are plenty of places in the dist where people just go through `sed`.
so am i missing something or is this all purely vestigial ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20101208/25fae0b3/attachment.pgp>
next reply other threads:[~2010-12-08 8:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-08 8:50 Mike Frysinger [this message]
2010-12-08 19:26 ` [Buildroot] helper tool handling in build system (sed/install/...) Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201012080350.46424.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox