Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] toolchain: speed up sysroot lib copying
Date: Mon, 13 Dec 2010 22:26:39 +0100	[thread overview]
Message-ID: <20101213222639.5455b0aa@surf> (raw)
In-Reply-To: <1292171120-32512-1-git-send-email-vapier@gentoo.org>

On Sun, 12 Dec 2010 11:25:20 -0500
Mike Frysinger <vapier@gentoo.org> wrote:

> The copy_toolchain_lib_root helper searches the entire sysroot, but is
> only interested in files in certain subdirs.  So rather than waste time
> in walking the entire tree, walk the few subdirs at the depth level we
> are actually going to be poaching files from.
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
>  toolchain/helpers.mk |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/toolchain/helpers.mk b/toolchain/helpers.mk
> index 05d43e7..674e7b4 100644
> --- a/toolchain/helpers.mk
> +++ b/toolchain/helpers.mk
> @@ -24,7 +24,10 @@ copy_toolchain_lib_root = \
>  	STRIP="$(strip $4)"; \
>   \
>  	LIBS=`(cd $${ARCH_SYSROOT_DIR}; \
> -		find -L . -path "./lib/$${LIB}.*"     -o \
> +		find -L \
> +			  ./lib/ ./usr/lib/ ./usr/$(TOOLCHAIN_EXTERNAL_PREFIX)/lib*/ \
> +			  -maxdepth 1 \
> +			  -path "./lib/$${LIB}.*"     -o \
>  			  -path "./usr/lib/$${LIB}.*" -o \
>  			  -path "./usr/$(TOOLCHAIN_EXTERNAL_PREFIX)/lib*/$${LIB}.*" \
>  		)` ; \

Can't we replace the 3 -path conditions with a single -name "$${LIB}.*"
condition ?

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2010-12-13 21:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-12 16:25 [Buildroot] [PATCH] toolchain: speed up sysroot lib copying Mike Frysinger
2010-12-13 21:26 ` Thomas Petazzoni [this message]
2010-12-13 22:10   ` Mike Frysinger
2010-12-13 22:23 ` Lionel Landwerlin
2010-12-13 23:13   ` Mike Frysinger
2010-12-14 20:59 ` [Buildroot] [PATCH v2] " Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101213222639.5455b0aa@surf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox