Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] buildroot:download: Add option to download SVN or GIT repository with version control information.
Date: Mon, 20 Dec 2010 17:08:50 +0100	[thread overview]
Message-ID: <20101220170850.78a29a16@surf> (raw)
In-Reply-To: <1292861049.2560.17.camel@dubciaranr0.verifone.com>

On Mon, 20 Dec 2010 16:04:09 +0000
Quotient Remainder <quotientvremainder@gmail.com> wrote:

> Lets say that you've cloned a GIT repository for PKG_X a few weeks ago
> and done a build, now you get a new configuration (probably by changing
> "local.mk" in my understanding of your scheme) and the version string
> for PKG_X now contains a value that is not present in the local clone.
> So, you type "make" and Buildroot tries to check out the specified new
> version, which will fail since the reference is unknown.  At this stage,
> I propose that Buildroot should attempt to get an update from upstream
> (git fetch origin) and then attempt to check out the version again,
> failing if this isn't possible.  It just makes things easier when
> there's distributed development going on that an individual wouldn't
> have to manually update every repository that is used (in my current
> project I have in excess of 40 and this will probably reach 100 before
> the project is complete).
> A similar principle applies more directly for SVN repository versions,
> since version checkouts are on-line.

The idea is that if you override the source directory of a package with
<pkg>_OVERRIDE_DIR, Buildroot wouldn't look at <pkg>_VERSION anymore.
It's completely up to the developer to use <pkg>_OVERRIDE_DIR to point
to a directory that contains the correct version for the sources.

> Once possible problem I envisage with this is that the built objects in
> these overridden directories will stick around.  This may lead to
> problems.  I suppose the clean/distclean/mrproper target for these could
> be called but it's hardly the most reliable approach.  You may have a
> cleaner solution in mind.

I haven't thought too much, but there are clearly issues that needs to
be solved. For example when a given package is compiled once for the
target and once for the host.

> > What I meant here is that components that are fetched from tarballs are
> > not being handled by Sonic's approach.
> 
> Aha, I think you mean that the OVERRIDE_DIR applies regardless of where
> the package comes from.  Right?

Yes.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2010-12-20 16:08 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-16  9:49 [Buildroot] [PATCH v2] buildroot:download: Add option to download SVN or GIT repository with version control information Sonic Zhang
2010-12-16  9:49 ` [Buildroot] [PATCH v2] buildroot:linux: Add options to checkout Linux kernel source from SVN or GIT repository Sonic Zhang
2010-12-17 10:40   ` Thomas Petazzoni
2010-12-16 14:19 ` [Buildroot] [PATCH v2] buildroot:download: Add option to download SVN or GIT repository with version control information Quotient Remainder
2010-12-17  2:44   ` Sonic Zhang
2010-12-16 21:22 ` Lionel Landwerlin
2010-12-17  2:52   ` Sonic Zhang
2010-12-17 10:34 ` Thomas Petazzoni
2010-12-17 13:11   ` Quotient Remainder
2010-12-20 14:05     ` Thomas Petazzoni
2010-12-20 16:04       ` Quotient Remainder
2010-12-20 16:08         ` Thomas Petazzoni [this message]
2010-12-20 16:37           ` Quotient Remainder
2010-12-20 16:47             ` Thomas Petazzoni
2010-12-20  9:11   ` Sonic Zhang
2010-12-20 11:37     ` Daniel Nyström

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101220170850.78a29a16@surf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox