Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [Bug 2875] Kernel doesn't build Ext2 support out-of-the-box
Date: Wed, 22 Dec 2010 11:23:50 +0100	[thread overview]
Message-ID: <20101222112350.7261db18@surf> (raw)
In-Reply-To: <87mxnyung0.fsf@macbook.be.48ers.dk>

Hello,

On Wed, 22 Dec 2010 11:11:27 +0100
Peter Korsgaard <jacmet@uclibc.org> wrote:

> I agree, but you're giving a bad example:
> 
> linux/linux.mk:
> ifeq ($(BR2_INET_IPV6),y)
>         $(call KCONFIG_ENABLE_OPT,CONFIG_IPV6,$(@D)/.config)
> else
>         $(call KCONFIG_DISABLE_OPT,CONFIG_IPV6,$(@D)/.config)
> endif
> 
> Which comes from:
> 
> commit 100c09a53b8806b2281a93ad21744d26f68bcc6b
> Author: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Date:   Tue Jun 8 13:56:19 2010 +0200
> 
>     linux: adjust kernel config according to the Buildroot configuration
>     
>     We only adjust the configuration or ARM EABI and IPv6. The (more
>     complicated) initramfs case is handled in a separate commit. The user
>     is expected to take care of all other configuration details (like
>     having Netfilter enabled to make iptables work, etc.)
>     
>     Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> 
> ;)

Notice that this commit was not *introducing* this, it was only
re-adding that feature into the new linux/linux.mk Makefile. See
http://git.buildroot.net/buildroot/tree/target/linux/Makefile.in.advanced?id=2010.05#n342 :-)

So, yes I'm contradicting myself, but not that much :-)

>  bugzilla> I will not mark the bug as WONTFIX, waiting for other
>  bugzilla> Buildroot developers to comment.
> 
> I vote for WONTFIX.

Ok. I think the IPv6 could also be removed (it's not because you have
an IPv6 capable toolchain that you necessarly want IPv6 in your kernel).
The EABI one is more or less justified, because we would otherwise have
hundreds of bug reports saying that userspace programs do not start.

Regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2010-12-22 10:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-02  7:48 [Buildroot] [Bug 2875] New: Kernel doesn't build Ext2 support out-of-the-box bugzilla at busybox.net
2010-12-22  9:14 ` [Buildroot] [Bug 2875] " bugzilla at busybox.net
2010-12-22 10:11   ` Peter Korsgaard
2010-12-22 10:23     ` Thomas Petazzoni [this message]
2010-12-22 10:43       ` Peter Korsgaard
2010-12-22 12:03         ` Gustavo Zacarias
2010-12-22 13:09 ` bugzilla at busybox.net

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101222112350.7261db18@surf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox