From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Thu, 23 Dec 2010 09:56:12 +0100 Subject: [Buildroot] [git commit master 1/1] ed: bump to version 1.5 In-Reply-To: <87vd2kswmm.fsf@macbook.be.48ers.dk> References: <20101222232249.DB1F38E20B@busybox.osuosl.org> <20101223082919.0d574cf8@surf> <87vd2kswmm.fsf@macbook.be.48ers.dk> Message-ID: <20101223095612.60df592b@surf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On Thu, 23 Dec 2010 09:48:17 +0100 Peter Korsgaard wrote: > Thomas> Sorry for this late review, but why is this ED_CONF_OPT needed ? We > Thomas> already pass those variables through TARGET_CONFIGURE_OPTS. > > Yes, it's a bit tricky. TARGET_CONFIGURE_OPTS are provided in the > environment, and the configure script overrides the variables > (CC=''). It then checks for a CC= argument and uses that, > otherwise it defaults to 'gcc'. Is that a configure script generated by autoconf ? Note that according to : http://www.gnu.org/prep/standards/html_node/Configuration.html It is recommended to pass the TARGET_CONFIGURE_OPTS as argument and not inside the environment: ? Specifying variables as arguments to configure, like this: ./configure CC=gcc is preferable to setting them in environment variables: CC=gcc ./configure as it helps to recreate the same configuration later with ?config.status?. However, both methods should be supported. ? Regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com