From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] v2 Add UBI image generation support.
Date: Thu, 23 Dec 2010 13:54:27 +0100 [thread overview]
Message-ID: <20101223135427.3876f009@surf> (raw)
In-Reply-To: <1292953087-19486-1-git-send-email-julien.boibessot@free.fr>
Hello,
Thanks Julien for this UBI support, it's definitely good to have in
Buildroot. This version looks good to me, but there is an alternate
solution (patch below, merged into Julien's patch).
Peter, we need you to make a decision here, between those two
solutions, because I have no strong opinion on which one is the best. To
summarize:
* Julien's solution is to create a new root filesystem type, called
"ubi", which depends on the "ubifs" filesystem to be generated. So
at build time, the rootfs.ubifs image is first generated, and then
the rootfs.ubi image is generated from rootfs.ubifs using ubinize.
You end up with rootfs.ubifs and rootfs.ubi in $(O)/images.
* The other solution proposed below is to not add a new root
filesystem type, but rather add a post-processing step to the
rootfs.ubifs image when "Embed in UBI image" is selected. You end up
with rootfs.ubifs in $(O)/images, regardless of whether it is a
UBIFS filesystem image, or a complete UBI image.
I just implemented the second solution because it's how I would have
implemented it if I had to do it, but I don't know if it's better or
not than Julien's proposal.
Regards,
Thomas
next prev parent reply other threads:[~2010-12-23 12:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-21 17:38 [Buildroot] [PATCH] v2 Add UBI image generation support julien.boibessot at free.fr
2010-12-23 12:54 ` Thomas Petazzoni [this message]
2010-12-23 15:36 ` Bjørn Forsman
2010-12-24 10:03 ` Julien Boibessot
2010-12-25 11:18 ` Thomas Petazzoni
2011-01-11 21:41 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101223135427.3876f009@surf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox