From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Makefile.package.in: fix upper case $(PKG)_SITE_METHOD
Date: Tue, 1 Feb 2011 21:34:33 +0100 [thread overview]
Message-ID: <20110201213433.1d527342@surf> (raw)
In-Reply-To: <1296559129-5595-1-git-send-email-bjorn.forsman@gmail.com>
On Tue, 1 Feb 2011 12:18:49 +0100
Bj?rn Forsman <bjorn.forsman@gmail.com> wrote:
> case "$($(PKG)_SITE_METHOD)" in \
> - git) $($(DL_MODE)_GIT) && exit ;; \
> - svn) $($(DL_MODE)_SVN) && exit ;; \
> - bzr) $($(DL_MODE)_BZR) && exit ;; \
> + GIT) $($(DL_MODE)_GIT) && exit ;; \
> + SVN) $($(DL_MODE)_SVN) && exit ;; \
> + BZR) $($(DL_MODE)_BZR) && exit ;; \
> *) $(call $(DL_MODE)_WGET,$(1),$(2)) && exit ;; \
> esac ; \
> fi ; \
No. This is going to break:
# Try automatic detection using the scheme part of the URI
$(2)_SITE_METHOD = $(firstword $(subst ://, ,$(call qstrip,$($(2)_SITE))))
is used to detect the site method from the URI, like :
git://....
or
svn://....
so if only upper case site methods are accepted, it's not going to work.
And more generally, I'd prefer to keep the existing lower-case writing
of the site method, since it is coherent with how it's written in the
URI.
Regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2011-02-01 20:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-01 11:18 [Buildroot] [PATCH] Makefile.package.in: fix upper case $(PKG)_SITE_METHOD Bjørn Forsman
2011-02-01 20:34 ` Thomas Petazzoni [this message]
2011-02-01 20:51 ` Daniel Nyström
2011-02-01 21:00 ` Thomas Petazzoni
2011-02-01 21:19 ` Bjørn Forsman
2011-02-01 21:30 ` Bjørn Forsman
2011-02-01 21:36 ` Bjørn Forsman
2011-02-01 21:41 ` Daniel Nyström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110201213433.1d527342@surf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox