Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] Binary ATI driver package in buildroot
Date: Wed, 6 Apr 2011 16:42:59 +0200	[thread overview]
Message-ID: <20110406164259.561b2511@surf> (raw)
In-Reply-To: <BANLkTinVhQdOqVJdkO9gK8Q==1j1uf_=BA@mail.gmail.com>

Hello Allan,

(It would be better to keep the Buildroot list CC'ed)

On Wed, 6 Apr 2011 16:34:42 +0200
Allan Nielsen <a@awn.dk> wrote:

> > However, your package does not use the GENTARGETS infrastructure,
> > which it should do. We don't include packages that don't rely on
> > one of the GENTARGETS, AUTOTARGETS or CMAKETARGETS infrastructure.
> 
> I'am converting it to GENTARGETS right now, but I'am having some
> problem with the extracting step, here is what I tried:
> 
> define FGLRX_EXTRACT_CMDS
>         mkdir -p $(@D)
>         sh $(DL_DIR)/$(FGLRX_SOURCE) --extract $(@D)
> endef
> 
> But for some reason this does not seems to have any effect, hare are a
> snippet from the output:
> 
> echo ">>> fglrx 11-2 "Extracting""
> mkdir -p /home/awn/git/buildroot/output/build/fglrx-11-2
> /home/awn/src/ati-driver-installer-11-2-x86.x86_64.run | tar
> --strip-components=1 -C
> /home/awn/git/buildroot/output/build/fglrx-11-2  -xf -
> chmod -R ug+rw /home/awn/git/buildroot/output/build/fglrx-11-2
> touch /home/awn/git/buildroot/output/build/fglrx-11-2/.stamp_extracted
> 
> Is this not the correct way to use GENTARGETS?

Unfortunately for the moment, it is not possible to override the
extraction step of a package by defining the <pkg>_EXTRACT_CMDS
variable. Buildroot asumes that each package is a tarball that can be
extracted as usual.

There are however several packages (usually non-open source stuff) with
strange extraction needs, so it would be great to be able to override
this step.

As a hack, you can do something like:

$(BUILD_DIR)/dhrystone-$(DHRYSTONE_VERSION)/.stamp_extracted:
        @$(call MESSAGE,"Extracting")
        $(Q)mkdir -p $(@D)
        $(Q)cd $(@D) && $(SHELL) $(DL_DIR)/$($(PKG)_SOURCE)
        $(Q)cp $($(PKG)_DIR_PREFIX)/dhrystone/Makefile $(@D)/
        $(Q)touch $@

(see package/dhrystone/dhryistone.mk)

Or if you want to do it the clean way, add the possibility of
overriding the extraction step in the package infrastructure.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  parent reply	other threads:[~2011-04-06 14:42 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-06 11:20 [Buildroot] Binary ATI driver package in buildroot Allan W. Nielsen
2011-04-06 11:20 ` [Buildroot] [PATCH] fglrx: Added package for ATI's binary device driver Allan W. Nielsen
2011-04-06 13:35 ` [Buildroot] Binary ATI driver package in buildroot Thomas Petazzoni
     [not found]   ` <BANLkTinVhQdOqVJdkO9gK8Q==1j1uf_=BA@mail.gmail.com>
2011-04-06 14:42     ` Thomas Petazzoni [this message]
2011-04-07 12:51       ` Allan Nielsen
2011-04-07  6:37   ` [Buildroot] Apache CrossCompile recipe Michael Burghart
2011-04-07  6:59     ` [Buildroot] [OT] " Patryk Benderz
     [not found]     ` <4D9D6EDE.7050004@daccii.it>
     [not found]       ` <4D9D6F6B.6000801@michaelburghart.de>
     [not found]         ` <4D9D7131.3090705@itechcon.it>
2011-04-07  8:20           ` [Buildroot] " Michael Burghart
     [not found]             ` <4D9D75DB.2010005@itechcon.it>
     [not found]               ` <4D9D775A.5010506@michaelburghart.de>
     [not found]                 ` <4D9D7EE5.6060200@itechcon.it>
     [not found]                   ` <4D9DE9B2.1000100@michaelburghart.de>
     [not found]                     ` <4D9DFE83.3080602@itechcon.it>
2011-04-07 18:22                       ` Michael Burghart
2011-04-08  5:58                       ` [Buildroot] Making kernel? Michael Burghart
2011-04-08  7:26                         ` Michael Burghart
2011-04-08  7:32                           ` Michael Burghart
2011-04-08  7:50                             ` bruce bushby
2011-04-08  9:20                               ` Michael Burghart
     [not found]                       ` <4D9E5FAD.8020408@michaelburghart.de>
     [not found]                         ` <4D9EFFBE.70308@itechcon.it>
2011-04-08 12:50                           ` [Buildroot] Apache CrossCompile recipe Michael Burghart
2011-04-08 13:15                             ` Daniele Salvatore Albano
2011-04-13 14:53                               ` Michael Burghart
2011-04-09  6:12                           ` Michael Burghart
2011-04-09 23:20                             ` bruce bushby
2011-04-09 23:49                               ` Michael Burghart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110406164259.561b2511@surf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox