From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] external toolchain: add arbitrary arguments to sysroot discovery and toolchain wrapper
Date: Sun, 8 May 2011 19:04:00 +0200 [thread overview]
Message-ID: <20110508190400.43407143@surf> (raw)
In-Reply-To: <4DC46EC4.2060000@rossvideo.com>
Hello Mathias,
On Fri, 06 May 2011 17:57:24 -0400
Matias Garcia <mgarcia@rossvideo.com> wrote:
> CodeSourcery uses non-standard arguments to determine which sysroot
> to use and to set other optimizations (e.g. which floating point ABI
> to use). This patch allows one to pass an arbitrary argument to the
> sysroot discovery in ext-tool.mk and adds the same option to the
> argument list in ext-toolchain-wrapper.c. I have not tested it with
> an empty option. Use at your own risk as this is my first open-source
> patch ever... (Am I supposed to write 'signed-off by...'?)
While the goal is correct, I don't like this implementation. The
toolchain wrapper should just make use of the flags in
BR2_TARGET_OPTIMIZATION configuration option, and not only -march,
-mtune, -mabi, etc. options which are currently being used.
Regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2011-05-08 17:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-06 21:57 [Buildroot] [PATCH] external toolchain: add arbitrary arguments to sysroot discovery and toolchain wrapper Matias Garcia
2011-05-08 17:04 ` Thomas Petazzoni [this message]
2011-05-10 13:25 ` Matias Garcia
[not found] ` <1305733040.7239.20.camel@matias-lnx-host>
2011-05-18 16:02 ` Thomas Petazzoni
2011-05-18 21:17 ` Matias Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110508190400.43407143@surf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox