Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Makefile.package.in: Makes it possible to override the default extract commands
Date: Wed, 18 May 2011 17:27:48 +0200	[thread overview]
Message-ID: <20110518172748.70078d60@surf> (raw)
In-Reply-To: <BANLkTimPeuvXnL=Pv_nyBC2EpLLMd8H_Hg@mail.gmail.com>

Hello,

On Wed, 18 May 2011 16:39:42 +0200
Allan Nielsen <a@awn.dk> wrote:

> Hi Thomas
> 
> Sorry for not replaying the last couple of days, but I have been busy
> with some other concerns.
> 
> However, when I did a rebuild I did also realize the problems with the
> solution I suggested. Since then I changed the extract_cmd statement
> to also the same as you have suggested:
> 
> 430 $(2)_EXTRACT_CMDS ?= $(if $$($(2)_SOURCE),$$(INFLATE$$(suffix
> $$($(2)_SOURCE))) $(DL_DIR)/$$($(2)_SOURCE) | \
> 431 ????????$(TAR) $(TAR_STRIP_COMPONENTS)=1 -C $$($(2)_DIR)
> $(TAR_OPTIONS) -)
> 
> This solution has been working fine for me, (and it should make no
> difference if I changes it to your suggestion).

Ok.

> Anyways, I would like to know where you stand on this, do you think
> this solution to be included in buildroot or would you prefer to wait
> for a better suggestion?

I'm fine with your existing proposal. Could you repost a proper patch
with the quoting fixes, so that I can give it a test, and send my
Acked-by ?

Note however that we are pretty close to the 2011.05 release, so it is
quite likely that Peter will delay such infrastructure changes until
after the release. But that doesn't prevent us from making progress on
it, getting my Acked-by, and therefore be on track to merge it
post-2011.05.

Regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2011-05-18 15:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-10 11:34 [Buildroot] Custom extract command agian agian Allan W. Nielsen
2011-05-10 11:34 ` [Buildroot] [PATCH] Makefile.package.in: Makes it possible to override the default extract commands Allan W. Nielsen
2011-05-10 18:43   ` Thomas Petazzoni
2011-05-16 19:52     ` Thomas Petazzoni
2011-05-18 14:39       ` Allan Nielsen
2011-05-18 15:27         ` Thomas Petazzoni [this message]
2011-05-18 16:05           ` Allan Nielsen
  -- strict thread matches above, loose matches on Subject: below --
2011-05-19  6:25 a at awn.dk
2011-05-10  9:58 [Buildroot] Custom extract command again Allan W. Nielsen
2011-05-10  9:58 ` [Buildroot] [PATCH] Makefile.package.in: Makes it possible to override the default extract commands Allan W. Nielsen
2011-05-10  9:55 [Buildroot] Custom extract command again Allan W. Nielsen
2011-05-10  9:55 ` [Buildroot] [PATCH] Makefile.package.in: Makes it possible to override the default extract commands Allan W. Nielsen
2011-04-11 11:08 [Buildroot] New version of patch to provide custom extract procedures Allan W. Nielsen
2011-04-11 11:08 ` [Buildroot] [PATCH] Makefile.package.in: Makes it possible to override the default extract commands Allan W. Nielsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110518172748.70078d60@surf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox