From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] Add package statserial
Date: Mon, 6 Jun 2011 21:21:21 +0200 [thread overview]
Message-ID: <20110606212121.335044b2@skate> (raw)
In-Reply-To: <BANLkTi=bZM8DpVptAVzw13Xs4V0d7b2rVg@mail.gmail.com>
Hello Francis,
Le Mon, 6 Jun 2011 00:03:36 -0300,
Francis Mendes <francis.mendes@gmail.com> a ?crit :
> I needed this package and added it to Buildroot.
>
> Can anyone review the attached patch for any mistakes?
Thanks for this submission!
It would be nicer to attach the patch inline, as it is easier to make
comments through the patch.
Two comments :
* You should "select" BR2_PACKAGE_NCURSES instead of "depends on".
That's the dependency type we use for the dependency of programs on
libraries.
* Your statserial-1.1-fixmakefile.patch should have a header with a
description saying why it is needed, and with a Signed-off-by line.
From a quick read, I don't see why the patch is needed.
* Your installation line should be
$(INSTALL) -D -m 0755 $(@D)/statserial $(TARGET_DIR)/usr/bin/statserial
otherwise your statserial binary will be named "bin" in
$(TARGET_DIR)/usr if the usr/bin directory does not exist.
Otherwise, looks good.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2011-06-06 19:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 3:03 [Buildroot] Add package statserial Francis Mendes
2011-06-06 19:21 ` Thomas Petazzoni [this message]
2011-06-07 1:54 ` Francis Mendes
2011-06-07 10:33 ` Peter Korsgaard
2011-06-07 23:40 ` Francis Mendes
2011-06-12 11:09 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110606212121.335044b2@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox