Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] pcsc-lite and ccid support
Date: Tue, 12 Jul 2011 17:38:53 +0200	[thread overview]
Message-ID: <20110712173853.7ff2d5ce@skate> (raw)
In-Reply-To: <1310465437-30946-1-git-send-email-ruckuus@gmail.com>

Le Tue, 12 Jul 2011 17:10:37 +0700,
ruckuus at gmail.com a ?crit :

> +config BR2_PACKAGE_CCID
> +	bool "ccid"
> +	select BR2_PACKAGE_PKG_CONFIG

No, I don't think you need pkg-config on the target.

> +CCID_DEPENDENCIES = pkg-config libusb pcsc-lite

Are you really sure you need pkg-config on the target ? Usually,
pkg-config is needed in the host. In this case, add "host-pkg-config"
to the DEPENDENCIES variable, and do not "select" anything related to
BR2_PACKAGE_PKG_CONFIG in the Config.in file.

> +$(eval $(call AUTOTARGETS, package, ccid))

No space after the commas:

$(eval $(call AUTOTARGETS,package,ccid))

> diff --git a/package/pcsc-lite/Config.in b/package/pcsc-lite/Config.in
> new file mode 100644
> index 0000000..55ac6d3
> --- /dev/null
> +++ b/package/pcsc-lite/Config.in
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_PCSC_LITE
> +	bool "pcsc-lite"
> +	select BR2_PACKAGE_LIBUSB
> +	help
> +	  Middleware to access a smart card using SCard API (PC/SC).
> +	  For more information, please visit:
> +	  http://pcsclite.alioth.debian.org/pcsclite.html
> +
> diff --git a/package/pcsc-lite/pcsc-lite.mk b/package/pcsc-lite/pcsc-lite.mk
> new file mode 100644
> index 0000000..2fdda5f
> --- /dev/null
> +++ b/package/pcsc-lite/pcsc-lite.mk
> @@ -0,0 +1,13 @@
> +##########################################################
> +#
> +# PCSC-Lite
> +#
> +# ########################################################
> +PCSC_LITE_VERSION = 1.7.4
> +PCSC_LITE_SOURCE = pcsc-lite-$(PCSC_LITE_VERSION).tar.bz2
> +PCSC_LITE_SITE = https://alioth.debian.org/frs/download.php/3598
> +PCSC_LITE_INSTALL_STAGING = YES
> +PCSC_LITE_INSTALL_TARGET = YES
> +PCSC_LITE_CONF_OPT = --disable-libudev --enable-libusb --enable-embedded

According to your Config.in, this package depends on LIBUSB. If it is
indeed the case, then libusb should be in the DEPENDENCIES variable of
this package.

> +$(eval $(call AUTOTARGETS, package, pcsc-lite))

No spaces after commas.

$(eval $(call AUTOTARGETS,package,pcsc-lite))

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2011-07-12 15:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-12 10:10 [Buildroot] [PATCH] pcsc-lite and ccid support ruckuus at gmail.com
2011-07-12 15:38 ` Thomas Petazzoni [this message]
2011-07-12 17:07   ` Dwi Sasongko Supriyadi
2011-07-13  7:38     ` Dwi Sasongko Supriyadi
2011-07-13  8:29       ` Thomas Petazzoni
  -- strict thread matches above, loose matches on Subject: below --
2011-07-12 17:04 ruckuus at gmail.com
2011-07-12  6:28 ruckuus at gmail.com
2011-07-12  6:43 ` Thomas Petazzoni
2011-07-12  7:03   ` Dwi Sasongko Supriyadi
2011-07-12  7:17     ` Thomas Petazzoni
2011-07-12 10:10       ` Dwi Sasongko Supriyadi
2011-07-12 11:50         ` Thomas Petazzoni
2011-07-12 15:07           ` Dwi Sasongko Supriyadi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110712173853.7ff2d5ce@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox