From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] toolchain: add user defined target LDFLAGS options
Date: Mon, 25 Jul 2011 10:10:01 +0300 [thread overview]
Message-ID: <20110725071001.GA13998@sapphire.tkos.co.il> (raw)
In-Reply-To: <87y5zmuauq.fsf@macbook.be.48ers.dk>
Hi Peter,
On Mon, Jul 25, 2011 at 08:34:53AM +0200, Peter Korsgaard wrote:
> >>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:
> Baruch> Allow the user to specify additional options for the target
> Baruch> LDFLAGS. I use this to pass the -te500v2 option to the linker,
> Baruch> when using the CodeSourcery toolchain for PowerPC. This chooses
> Baruch> the correct CRT for e500 hard float. Otherwise I get errors
> Baruch> like
>
> Committed, thanks.
>
> What tree did you create this patch against? package/Makefile.in hasn't
> looked like that since April, so I had to apply the patch manually.
I mistakenly based this patch on version 2010.11.
Actually, since I use an external toolchain, the patch of Matias Garcia
(http://lists.busybox.net/pipermail/buildroot/2011-July/043944.html, not
merged yet) solves the -te500v2 problem for me without this patch, so I've
dropped it locally.
> Baruch> ---
> Baruch> package/Makefile.in | 2 +-
> Baruch> toolchain/toolchain-common.in | 5 +++++
> Baruch> 2 files changed, 6 insertions(+), 1 deletions(-)
>
> Baruch> diff --git a/package/Makefile.in b/package/Makefile.in
> Baruch> index 2ca8c31..a6cee06 100644
> Baruch> --- a/package/Makefile.in
> Baruch> +++ b/package/Makefile.in
> Baruch> @@ -81,7 +81,7 @@ ifeq ($(BR2_TOOLCHAIN_BUILDROOT),y)
> Baruch> TARGET_CFLAGS+=-I$(STAGING_DIR)/usr/include -I$(STAGING_DIR)/include
> Baruch> endif
>
> Baruch> -TARGET_LDFLAGS+=-L$(STAGING_DIR)/lib -L$(STAGING_DIR)/usr/lib
> Baruch> +TARGET_LDFLAGS+=-L$(STAGING_DIR)/lib -L$(STAGING_DIR)/usr/lib $(BR2_TARGET_LDFLAGS)
>
> You need to use qstrip as otherwise all the flags will be handled as a
> single argument.
Ah, something new learnt. Thanks for noticing and fixing, and thanks again for
your great work.
(Back to my cross Poco C++ build attempts)
baruch
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2011-07-25 7:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-23 9:21 [Buildroot] [PATCH] toolchain: add user defined target LDFLAGS options Baruch Siach
2011-07-25 6:34 ` Peter Korsgaard
2011-07-25 7:10 ` Baruch Siach [this message]
2011-07-25 7:16 ` Peter Korsgaard
2011-07-25 7:24 ` Baruch Siach
2011-07-25 7:28 ` Peter Korsgaard
2011-07-25 21:19 ` Matias Garcia
2011-07-26 13:10 ` Baruch Siach
2011-07-26 15:00 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110725071001.GA13998@sapphire.tkos.co.il \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox