From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Fix sorting-related issue when using make 3.82
Date: Fri, 5 Aug 2011 17:34:38 +0200 [thread overview]
Message-ID: <20110805173438.4bc1285f@skate> (raw)
In-Reply-To: <b48283f33363fb03ff99.1312556072@localhost6.localdomain6>
Hello Thomas,
The commit log should be wrapped to ~80 columns.
Le Fri, 05 Aug 2011 16:54:32 +0200,
Thomas De Schampheleire <patrickdepinguin+buildroot@gmail.com> a ?crit :
> In make 3.82, wildcards are no longer sorted. This impacts lines like:
> include package/*/*.mk
>
> A specific scenario under which this fails: if the .mk file of an autotools-based package with FOO_AUTORECONF set to yes, happens to be included before the autoconf/autoconf.mk file, the $(AUTORECONF) variable is not yet set and autoreconfiguration fails with the following message:
I don't think it is the right fix, because there shouldn't be
things that depend on the order of inclusion of the various packages.
> caused by the following statement in package/Makefile.autotools.in:
> $(Q)cd $$($$(PKG)_SRCDIR) && $(AUTORECONF) $$($$(PKG)_AUTORECONF_OPT)
Can you try to use $$(AUTORECONF) instead of $(AUTORECONF) ?
Regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2011-08-05 15:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-05 14:54 [Buildroot] [PATCH] Fix sorting-related issue when using make 3.82 Thomas De Schampheleire
2011-08-05 15:34 ` Thomas Petazzoni [this message]
2011-08-08 11:39 ` Thomas De Schampheleire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110805173438.4bc1285f@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox