From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] add QWT library: Qt Widgets for Technical Applications
Date: Sat, 6 Aug 2011 08:58:14 +0200 [thread overview]
Message-ID: <20110806085814.71636ff4@skate> (raw)
In-Reply-To: <1312591577-30383-1-git-send-email-ivan.kuten@promwad.com>
Hello Ivan,
Looks a lot better. A few comments remain though (sorry if I didn't
catch them at the first review).
Le Sat, 6 Aug 2011 03:46:17 +0300,
Ivan Kuten <ivan.kuten@promwad.com> a ?crit :
> +menuconfig BR2_PACKAGE_QWT
This should be:
config BR2_PACKAGE_QWT
menuconfig is here to define a submenu, which is not the case for qwt.
> +define QWT_INSTALL_STAGING_CMDS
> + (export INSTALL_ROOT=$(STAGING_DIR); $(MAKE) -C $(@D) install)
> +endef
> +
> +define QWT_INSTALL_TARGET_CMDS
> + cp -dpf $(STAGING_DIR)/usr/local/qwt-$(QWT_VERSION)/lib/libqwt.so* $(TARGET_DIR)/usr/lib
> +endef
This installation path of the library
($(STAGING_DIR)/usr/local/qwt-xxxx/lib/) is not a standard path, and
will make a lot of things fail in Buildroot. Can you arrange to install
the library in $(STAGING_DIR)/usr/lib and the headers files in
$(STAGING_DIR)/usr/include (i.e, define a prefix of $(STAGING_DIR)/usr).
Otherwise, looks good.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2011-08-06 6:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-04 21:02 [Buildroot] [PATCH] add QWT library: Qt Widgets for Technical Applications Ivan Kuten
2011-08-04 21:51 ` Thomas Petazzoni
2011-08-05 17:28 ` Ivan Kuten
2011-08-06 0:46 ` [Buildroot] [PATCH v2] " Ivan Kuten
2011-08-06 6:58 ` Thomas Petazzoni [this message]
2011-08-07 7:36 ` Peter Korsgaard
2011-08-10 13:04 ` Ivan Kuten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110806085814.71636ff4@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox