From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] toolchain: fix build with empty BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS
Date: Mon, 26 Sep 2011 09:17:30 +0200 [thread overview]
Message-ID: <20110926091730.3609c1fa@skate> (raw)
In-Reply-To: <6a4325eb6bbe6622b6a8b7d1bc3a7279866e6716.1317019552.git.baruch@tkos.co.il>
Le Mon, 26 Sep 2011 09:46:43 +0300,
Baruch Siach <baruch@tkos.co.il> a ?crit :
> # march/mtune/floating point mode needs to be passed to the external toolchain
> # to select the right multilib variant
> -ifneq ($(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS),)
> +ifneq ($(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS),"")
> TOOLCHAIN_EXTERNAL_CFLAGS += $(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)
> TOOLCHAIN_EXTERNAL_WRAPPER_ARGS += -DBR_OPT='$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)'
> endif
We typically use qstrip for this kind of things:
TOOLCHAIN_EXTERNAL_CUSTOM_ARGS = $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS))
ifneq ($(TOOLCHAIN_EXTERNAL_CUSTOM_ARGS),)
TOOLCHAIN_EXTERNAL_CFLAGS += $(TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)
TOOLCHAIN_EXTERNAL_WRAPPER_ARGS += -DBR_OPT='$(TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)'
endif
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2011-09-26 7:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-26 6:46 [Buildroot] [PATCH] toolchain: fix build with empty BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS Baruch Siach
2011-09-26 7:17 ` Thomas Petazzoni [this message]
2011-09-26 7:40 ` Baruch Siach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110926091730.3609c1fa@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox