Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] add libfcgi to buildroot it will have compiling errors as long as -lm isnt added to the buildsystem of libfcgi
Date: Wed, 28 Sep 2011 16:30:20 +0200	[thread overview]
Message-ID: <20110928163020.6350cc9b@skate> (raw)
In-Reply-To: <1317219200-4655-1-git-send-email-bachmann@tofwerk.com>

Hello,

Good for the usage of git send-email!

The patch title is too long. There should be one first line of < 80
characters, and then if you need to put some other details: one blank
line, and then some other paragraphs.

And the -lm problem should be fixed rather than explained in the commit
log :-)

Le Wed, 28 Sep 2011 16:13:20 +0200,
Rico Bachmann <bachmann@tofwerk.com> a ?crit :

> +##############################################################################
> +#
> +# libfcgi
> +#
> +##############################################################################
> +LIBFCGI_VERSION = 2.4.0
> +LIBFCGI_SOURCE = fcgi-$(LIBFCGI_VERSION).tar.gz
> +LIBFCGI_SITE = http://www.fastcgi.com/dist
> +LIBFCGI_INSTALL_STAGING = YES
> +LIBFCGI_INSTALL_TARGET = YES

Line not needed, this is the default.

> +LIBFCGI_CONF_OPT = --enable-shared

Line not needed, this is already part of the default configuration
options.

Regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2011-09-28 14:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <add fcgi-2.4.0 package to buildroot>
2011-09-28 14:13 ` [Buildroot] [PATCH] add libfcgi to buildroot it will have compiling errors as long as -lm isnt added to the buildsystem of libfcgi Rico Bachmann
2011-09-28 14:30   ` Thomas Petazzoni [this message]
2011-09-28 15:02     ` Rico Bachmann
2011-09-28 15:49       ` Thomas Petazzoni
2011-09-28 15:52       ` Rico Bachmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110928163020.6350cc9b@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox