From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2] toolchain: fix build with empty BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS
Date: Sun, 2 Oct 2011 08:50:23 +0200 [thread overview]
Message-ID: <20111002065023.GA24034@tarshish> (raw)
In-Reply-To: <20111002062258.GA14908@tarshish>
Hi Buildroot list,
On Sun, Oct 02, 2011 at 08:22:58AM +0200, Baruch Siach wrote:
> On Mon, Sep 26, 2011 at 10:48:57AM +0300, Baruch Siach wrote:
> > The "" string is not equal to the empty string. This fixes build
> > errors like:
> >
> > arm-none-linux-gnueabi-gcc: : No such file or directory
> >
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>
> Ping?
> This fixes a real build breakage of the combination of external toolchain and
> empty BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS.
Forget it. This patch is against some local modifications for mine (a patch
that has been posted here a few months ago, but never applied).
Sorry for the noise.
baruch
> > ---
> > Changes v1 -> v2:
> > * Use qstrip as suggested by Thomas Petazzoni
> > * Add build failure example to commit log for future reference
> >
> > toolchain/toolchain-external/ext-tool.mk | 3 ++-
> > 1 files changed, 2 insertions(+), 1 deletions(-)
> >
> > diff --git a/toolchain/toolchain-external/ext-tool.mk b/toolchain/toolchain-external/ext-tool.mk
> > index a357cb9..bf59983 100644
> > --- a/toolchain/toolchain-external/ext-tool.mk
> > +++ b/toolchain/toolchain-external/ext-tool.mk
> > @@ -131,7 +131,8 @@ CC_TARGET_ABI_:=$(call qstrip,$(BR2_GCC_TARGET_ABI))
> >
> > # march/mtune/floating point mode needs to be passed to the external toolchain
> > # to select the right multilib variant
> > -ifneq ($(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS),)
> > +TOOLCHAIN_EXTERNAL_CUSTOM_ARGS = $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS))
> > +ifneq ($(TOOLCHAIN_EXTERNAL_CUSTOM_ARGS),)
> > TOOLCHAIN_EXTERNAL_CFLAGS += $(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)
> > TOOLCHAIN_EXTERNAL_WRAPPER_ARGS += -DBR_OPT='$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)'
> > endif
> > --
> > 1.7.6.3
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
prev parent reply other threads:[~2011-10-02 6:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-26 7:48 [Buildroot] [PATCHv2] toolchain: fix build with empty BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS Baruch Siach
2011-09-27 21:51 ` Thomas Petazzoni
2011-10-02 6:22 ` Baruch Siach
2011-10-02 6:50 ` Baruch Siach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111002065023.GA24034@tarshish \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox