From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] bump libosip2 3.3.0 ->3.5.0
Date: Thu, 8 Dec 2011 22:32:20 +0100 [thread overview]
Message-ID: <20111208223220.232e9e51@skate> (raw)
In-Reply-To: <44F7530B252A4144827800C1F9838E11@JohanW7>
Hello,
Le Wed, 7 Dec 2011 11:28:19 +0100,
"Sagaert Johan" <sagaert.johan@skynet.be> a ?crit :
> Bump version
Few comments:
* No need to mention "Bump version" as the long description as it
doesn't add anything to the short description
* You must add a Signed-off-by line to your patches.
* Your patch is word-wrapped. Check your e-mail client settings, or
better, use git send-email to send your patches.
* Do not keep commented lines in your patch?
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
prev parent reply other threads:[~2011-12-08 21:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-07 10:28 [Buildroot] [PATCH 1/1] bump libosip2 3.3.0 ->3.5.0 Sagaert Johan
2011-12-08 21:32 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111208223220.232e9e51@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox