From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] New Package libmbus library for communicating with M-bus devices.(rework)
Date: Sat, 10 Dec 2011 15:46:19 +0100 [thread overview]
Message-ID: <20111210154619.2fdaccf8@skate> (raw)
In-Reply-To: <1323478080-2915-1-git-send-email-sagaert.johan@skynet.be>
Hello,
You forgot your Signed-off-by line, which is mandatory.
Le Sat, 10 Dec 2011 01:48:00 +0100,
Sagaert Johan <sagaert.johan@skynet.be> a ?crit :
> +++ b/package/libmbus/Config.in
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_LIBMBUS
> + bool "libmbus"
> + help
> + libmbus is a library for communicating with energy metering devices.
> + It supports TCP and RS232 M-bus gateways.
> + ( M-bus standard : http://www.m-bus.com/ )
Remove space after ( and before ).
> +LIBMBUS_VERSION:=0.6.1
= instead of :=
> +LIBMBUS_SOURCE:=libmbus-$(LIBMBUS_VERSION).tar.gz
Not needed, that's the default.
> +LIBMBUS_SITE:=http://www.freescada.com/public-dist/
= instead of :=
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2011-12-10 14:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-10 0:48 [Buildroot] [PATCH 1/1] New Package libmbus library for communicating with M-bus devices.(rework) Sagaert Johan
2011-12-10 14:46 ` Thomas Petazzoni [this message]
[not found] ` <8C82EF97265D4A6DA5ED238B24FD8DC0@JohanW7>
2011-12-11 12:40 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111210154619.2fdaccf8@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox