From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [pull request v2] Pull request for branch for-2011.11/pkg-device
Date: Wed, 14 Dec 2011 11:43:53 +0100 [thread overview]
Message-ID: <20111214114353.5a5e047a@skate> (raw)
In-Reply-To: <4EE87CEE.5050304@free-electrons.com>
Le Wed, 14 Dec 2011 11:39:42 +0100,
Maxime Ripard <maxime.ripard@free-electrons.com> a ?crit :
> Any review on that ?
I don't like the <pkg>_FILES name, because it makes me think that *all*
files installed by the package must be listed in this variable, while
in fact, only files for which special permissions must be applied, or
for device files.
What about having two variables:
<pkg>_PERMISSIONS
and
<pkg>_DEVICES
The idea is that by separating permission-modifications (like the one
for Busybox) for device files, it is much easier to use *_PERMISSIONS +
*_DEVICES when static /dev is used, and only *_PERMISSIONS when
dynamic /dev is used.
Regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
prev parent reply other threads:[~2011-12-14 10:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-09 14:05 [Buildroot] [pull request v2] Pull request for branch for-2011.11/pkg-device Maxime Ripard
2011-09-09 14:05 ` [Buildroot] [PATCH 1/4] Cleanup cramfs package declaration Maxime Ripard
2011-10-27 13:43 ` Peter Korsgaard
2011-09-09 14:05 ` [Buildroot] [PATCH 2/4] Rename the device table in the code base Maxime Ripard
2011-09-09 14:05 ` [Buildroot] [PATCH 3/4] Add support for package-declared devices Maxime Ripard
2011-09-09 14:05 ` [Buildroot] [PATCH 4/4] Convert busybox to the device declaration method Maxime Ripard
2011-09-30 21:52 ` [Buildroot] [pull request v2] Pull request for branch for-2011.11/pkg-device Maxime Ripard
2011-12-14 10:39 ` Maxime Ripard
2011-12-14 10:43 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111214114353.5a5e047a@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox