Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4 of 4 v3] dependencies: build a host-tar if no suitable tar can be found
Date: Wed, 14 Dec 2011 15:29:21 +0100	[thread overview]
Message-ID: <20111214152921.72ddc4b0@skate> (raw)
In-Reply-To: <bc11accdafb5b8b0d945.1323862800@devws108>

Le Wed, 14 Dec 2011 15:22:18 +0100,
Thomas De Schampheleire <patrickdepinguin+buildroot@gmail.com> a ?crit :

> +HOST_TAR_EXTRACT_CMDS = \
> +	mkdir -p $(HOST_TAR_DIR) && cd $(HOST_TAR_DIR) && \
> +	$(INFLATE.gz) $(DL_DIR)/$(HOST_TAR_SOURCE) | cpio -i && \
> +	mv tar-$(TAR_VERSION)/* . && rmdir tar-$(TAR_VERSION)

I would prefer

define HOST_TAR_EXTRACT_CMDS
	...
endef

here.

I haven't checked the details, but I'm fine with the general approach.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

      reply	other threads:[~2011-12-14 14:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-14 14:21 [Buildroot] [PATCH 0 of 4 v3] dependencies: some improvements Thomas De Schampheleire
2011-12-14 14:22 ` [Buildroot] [PATCH 1 of 4 v3] dependencies: move from toolchain/ to support/ Thomas De Schampheleire
2011-12-14 14:22 ` [Buildroot] [PATCH 2 of 4 v3] dependencies: check minimal make version early on Thomas De Schampheleire
2011-12-14 14:25   ` Thomas Petazzoni
2011-12-14 14:22 ` [Buildroot] [PATCH 3 of 4 v3] dependencies: add function suitable-host-package Thomas De Schampheleire
2011-12-14 14:29   ` Thomas Petazzoni
2011-12-14 14:22 ` [Buildroot] [PATCH 4 of 4 v3] dependencies: build a host-tar if no suitable tar can be found Thomas De Schampheleire
2011-12-14 14:29   ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111214152921.72ddc4b0@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox