From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] New package: python-setuptools
Date: Wed, 21 Dec 2011 13:42:13 +0100 [thread overview]
Message-ID: <20111221134213.2f868bdc@skate> (raw)
In-Reply-To: <1324464775-9409-1-git-send-email-yegorslists@googlemail.com>
Le Wed, 21 Dec 2011 11:52:55 +0100,
yegorslists at googlemail.com a ?crit :
> +PYTHON_INSTALL_STAGING = YES
Your .mk file does not contain the build and install commands for a
target version of this package, so this line is useless.
> +PYTHON_SETUPTOOLS_DEPENDENCIES = python
Again, this won't be used since you have defined only a host variant
for your package. What you need is:
HOST_PYTHON_SETUPTOOLS_DEPENDENCIES = host-python
> + (cd $(@D); PYTHONPATH="$(HOST_DIR)/usr/lib/python2.7/site-packages"\
Use $(PYTHON_VERSION_MAJOR) instead of hardcoding 2.7.
> +$(eval $(call GENTARGETS))
Remove this line this you haven't implemented a target variant for this
package.
> +source "package/python-setuptools/Config.in"
And remove the Config.in file altogether as you haven't implemented a
target variant for this package.
Of course, if you intend to also support building setuptools for the
target, keep the Config.in file and the $(eval $(call GENTARGETS))
line, but remember to implement the BUILD_CMDS and INSTALL_*_CMDS as
well.
Regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
prev parent reply other threads:[~2011-12-21 12:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-21 10:52 [Buildroot] [PATCH] New package: python-setuptools yegorslists at googlemail.com
2011-12-21 10:58 ` Yegor Yefremov
2011-12-21 12:38 ` Thomas Petazzoni
2011-12-21 12:42 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111221134213.2f868bdc@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox