From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] bash: Adding features that can not be automatically detected while cross-compiling
Date: Wed, 18 Jan 2012 12:30:52 +0100 [thread overview]
Message-ID: <201201181230.52774.arnout@mind.be> (raw)
In-Reply-To: <CA+gTGJFtJVTOeS8su7P2FnP4OMLFhbpvg6JMAymkL2uLs5+ogQ@mail.gmail.com>
On Wednesday 18 January 2012 07:37:30 Arkady Gilinsky wrote:
> On Wed, Jan 18, 2012 at 1:07 AM, Peter Korsgaard <jacmet@uclibc.org> wrote:
> >>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:
> >
> > Arnout> From: Arkady Gilinsky <arcadyg@gmail.com>
> >
> > Arnout> There are some bash features that can not be detected
> > Arnout> automatically during configure stage while
> > Arnout> cross-compiling. This commit adds the ability to force support
> > Arnout> of such features.
> >
> > Ok, but does it make sense to make these things configurable? I haven't
> > checked, but presumably these are supported on all Linux archs, and
> > don't affect the binary size significantly (compared to bash size)?
I don't think it does (that's what I meant to say in my review), but I
didn't want to force the issue without prior feedback.
> >
> > Couldn't we just always forcibly enable these instead?
Completely agree with that.
>
> I agree with you, Peter, that these features supported on many/almost
> all Linux archs, but
> current version of bash configuration in Buildroot has 'job_control'
> feature set to off.
> I didn't find the reason why (may be you know), so I decided to leave
> the ability to set it off
> for anybody who do not want/able to set this feature on.
> Also the default setting is off to not to break any existing build.
> If you find that these features should be forced set to on, inform me
> I will make an appropriate patch.
I'll post a v3 that does just that.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2012-01-18 11:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-15 17:14 [Buildroot] [PATCH] BASH: Adding features that can not be automatically detected while cross-compiling Arkady Gilinsky
2012-01-17 17:18 ` Arnout Vandecappelle
2012-01-17 22:40 ` Michael S. Zick
2012-01-17 22:49 ` Steve Calfee
2012-01-17 17:22 ` [Buildroot] [PATCH] BASH: Adding features that can not be automatically detected Arnout Vandecappelle
2012-01-17 17:25 ` [Buildroot] [PATCH v2] bash: Adding features that can not be automatically detected while cross-compiling Arnout Vandecappelle
2012-01-17 23:07 ` Peter Korsgaard
2012-01-18 6:37 ` Arkady Gilinsky
2012-01-18 11:30 ` Arnout Vandecappelle [this message]
2012-01-18 11:31 ` [Buildroot] [PATCH v3] " Arnout Vandecappelle
2012-01-18 12:42 ` Arkady Gilinsky
2012-01-19 12:22 ` [Buildroot] [PATCH v4] " Arnout Vandecappelle
2012-01-19 12:27 ` Arnout Vandecappelle
2012-01-20 8:23 ` Peter Korsgaard
2012-01-20 20:54 ` Arnout Vandecappelle
2012-01-22 20:57 ` Peter Korsgaard
2012-01-20 8:19 ` Peter Korsgaard
2012-01-18 11:36 ` [Buildroot] [PATCH v2] " Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201201181230.52774.arnout@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox