Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] poco: the Zip module depends on XML, Net and Util modules
Date: Mon, 6 Feb 2012 23:10:03 +0100	[thread overview]
Message-ID: <201202062310.04009.arnout@mind.be> (raw)
In-Reply-To: <3b38408088d90bd4c521eb6f35d73502c1d5f352.1328221763.git.thomas.petazzoni@free-electrons.com>

On Thursday 02 February 2012 23:29:25 Thomas Petazzoni wrote:
> Without this, in a configuration where the Zip module is selected but
> not the XML module, the build fails due to missing expat.h. This is
> because POCO builds the XML module as soon as the Zip module is
> enabled.
> 
> This fixes the build breakage visible at:
> 
>   http://free-electrons.com/~thomas/buildroot/test-output-2011-12-02/test-920-output.bz2
> 
> with the configuration visible at:
> 
>   http://free-electrons.com/~thomas/buildroot/test-output-2011-12-02/test-920-config

 Good idea to refer to the test.  However, will it exist there forever?  
If not, I'm not sure if it should be in the commit message.

> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

> ---
>  package/poco/Config.in |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/package/poco/Config.in b/package/poco/Config.in
> index 241e304..36d8de9 100644
> --- a/package/poco/Config.in
> +++ b/package/poco/Config.in
> @@ -37,6 +37,9 @@ config BR2_PACKAGE_POCO_NETSSL_OPENSSL
>  
>  config BR2_PACKAGE_POCO_ZIP
>  	bool "zip"
> +	select BR2_PACKAGE_POCO_XML
> +	select BR2_PACKAGE_POCO_NET
> +	select BR2_PACKAGE_POCO_UTIL
>  
>  config BR2_PACKAGE_POCO_DATA
>  	bool
> 

-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  reply	other threads:[~2012-02-06 22:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-02 22:29 [Buildroot] [pull request] Pull request for branch for-2012.02/misc Thomas Petazzoni
2012-02-02 22:29 ` [Buildroot] [PATCH 1/2] poco: the Zip module depends on XML, Net and Util modules Thomas Petazzoni
2012-02-06 22:10   ` Arnout Vandecappelle [this message]
2012-02-07 17:48     ` Thomas Petazzoni
2012-02-02 22:29 ` [Buildroot] [PATCH 2/2] at91bootstrap: allow specification of a custom patch directory Thomas Petazzoni
2012-02-02 22:42 ` [Buildroot] [pull request] Pull request for branch for-2012.02/misc Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201202062310.04009.arnout@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox